Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediawiki: 1.34.2 -> 1.35.0 #99490

Merged
merged 1 commit into from Oct 13, 2020
Merged

mediawiki: 1.34.2 -> 1.35.0 #99490

merged 1 commit into from Oct 13, 2020

Conversation

@rapenne-s
Copy link
Member

@rapenne-s rapenne-s commented Oct 3, 2020

Motivation for this change

This is the new LTS version of mediawiki, it also fixes a few CVE
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/1.35.0/RELEASE-NOTES-1.35

Note that from this version, you need at least php 7.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@aanderse
Copy link
Member

@aanderse aanderse commented Oct 4, 2020

@rapenne-s do you use the mediawiki module and/or package on NixOS? If so, do you have any interest in becoming a maintainer?

@aanderse
Copy link
Member

@aanderse aanderse commented Oct 4, 2020

@GrahamcOfBorg test mediawiki

redvers
redvers approved these changes Oct 5, 2020
Copy link
Member

@redvers redvers left a comment

There is a somewhat substantial list of deprecations in the changelog but nothing that seems to be hugely problematic.

They did deprecate an old version of php but nobody should be running that.

I'm still testing it for functionality - but it looks good to me.

@redvers
Copy link
Member

@redvers redvers commented Oct 5, 2020

I'm still testing it for functionality - but it looks good to me.

I should quantify this. My build environment for actually testing this was non-functional before I can even test it. I don't see anything in any of the changelogs that would indicate any issues - but I can't fully say it's 100% until I finish getting this test environment up.

My apologies for the confusion @aanderse

@redvers
Copy link
Member

@redvers redvers commented Oct 6, 2020

@aanderse - there may be a bug in the module as opposed to the package which is preventing me from testing this. I'll take a look at that too.

@rapenne-s rapenne-s closed this Oct 6, 2020
@rapenne-s rapenne-s deleted the update/mediawiki branch Oct 6, 2020
@rapenne-s rapenne-s restored the update/mediawiki branch Oct 6, 2020
@rapenne-s
Copy link
Member Author

@rapenne-s rapenne-s commented Oct 6, 2020

I accidentally deleted the branch on my fork which closed the PR.

@rapenne-s rapenne-s reopened this Oct 6, 2020
@ofborg ofborg bot requested a review from redvers Oct 6, 2020
@aanderse
Copy link
Member

@aanderse aanderse commented Oct 6, 2020

Am I correct in assuming this is resolved by this PR?

@rapenne-s
Copy link
Member Author

@rapenne-s rapenne-s commented Oct 6, 2020

Am I correct in assuming this is resolved by this PR?

The CVE description is the following so I guess yes.

resources/src/mediawiki.page.ready/ready.js in MediaWiki before 1.35 allows remote attackers to force a logout and external redirection via HTML content in a MediaWiki page.

I can't find which CVE from the changelog its correspond to though.

@aanderse
Copy link
Member

@aanderse aanderse commented Oct 13, 2020

This is security related so I'm going to merge in good faith this is tested sufficiently.

Thanks @rapenne-s 🎉 Are you able to backport to the release-20.09 branch via a git cherry-pick (as described in the manual) as well?

@aanderse aanderse merged commit 6635924 into NixOS:master Oct 13, 2020
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants