Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.fsspec: fix tests on linux #99499

Merged
merged 1 commit into from Oct 7, 2020

Conversation

@tricktron
Copy link
Contributor

@tricktron tricktron commented Oct 3, 2020

Motivation for this change

Disables flaky test. Has been resolved in intake/filesystem_spec#432 and
can thus be enabled again starting from version 0.8.4.

ZHF: #97479
cc: @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@tricktron tricktron requested review from FRidh and jonringer as code owners Oct 3, 2020
@tricktron
Copy link
Contributor Author

@tricktron tricktron commented Oct 3, 2020

@grahamc I read on another issue thread that you are the guy who has some knowledge about hydra. Do you know what filesystem the x86_64-linux hydra builder use?

@grahamc
Copy link
Member

@grahamc grahamc commented Oct 3, 2020

Some of them use ext4, some of them use ZFS.

@tricktron
Copy link
Contributor Author

@tricktron tricktron commented Oct 4, 2020

@grahamc Thanks for the quick answer. Is there a way to find out if the machine here uses zfs or ext4? And is there a quick way to debug/test hydra darwin failures as mentioned here?

@risicle
Copy link
Contributor

@risicle risicle commented Oct 5, 2020

Are we merging this either way?

Disables flaky test. Has been resolved in intake/filesystem_spec#432 and
can thus be enabled again starting from version `0.8.4`.
@tricktron tricktron force-pushed the tricktron:fix-fsspec-linux-take2 branch from 329a780 to 0a9641b Oct 7, 2020
@tricktron
Copy link
Contributor Author

@tricktron tricktron commented Oct 7, 2020

@risicle @jonringer I think it is ready to merge. Btw: #98619 can't wait to be merged too.😃

@risicle
risicle approved these changes Oct 7, 2020
Copy link
Contributor

@risicle risicle left a comment

WFM macos 10.14, non-nixos linux x86_64

Hit the button.

@risicle risicle merged commit 889a785 into NixOS:master Oct 7, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a9641b"; rev="0a9641b3bbc30e1cb6128b03e455b0a2925a7d55"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a9641b"; rev="0a9641b3bbc30e1cb6128b03e455b0a2925a7d55"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a9641b"; rev="0a9641b3bbc30e1cb6128b03e455b0a2925a7d55"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a9641b"; rev="0a9641b3bbc30e1cb6128b03e455b0a2925a7d55"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a9641b"; rev="0a9641b3bbc30e1cb6128b03e455b0a2925a7d55"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a9641b"; rev="0a9641b3bbc30e1cb6128b03e455b0a2925a7d55"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0a9641b"; rev="0a9641b3bbc30e1cb6128b03e455b0a2925a7d55"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@tricktron tricktron deleted the tricktron:fix-fsspec-linux-take2 branch Oct 8, 2020
@tricktron tricktron mentioned this pull request Oct 10, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.