Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.arviz: 0.7.0 -> 0.10.0, fixing tests #99500

Merged
merged 1 commit into from Oct 11, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 3, 2020

Motivation for this change

ZHF: #97479

This doesn't fix:

  • reverse dependency pymc3, which now shows its own build failure. Perhaps I will get onto that next.
  • building on darwin, which is blocked by broken dependency tensorflow there. I'm not touching that one with a bargepole.

There are also some existing suggestions in comments in this package of how more of the tests could be enabled, but I haven't done anything about that. Some tests it seems require pymc3, which, now, itself depends on arviz, so that's unlikely to happen unless we move some of the tests to a passthru.tests, which could depend on both by being outside the dependency cycle (?)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@risicle risicle requested review from FRidh and jonringer as code owners Oct 3, 2020
@risicle
Copy link
Contributor Author

@risicle risicle commented Oct 3, 2020

@ofborg build python37Packages.arviz python38Packages.arviz

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/99500
1 package failed to build:
python37Packages.pymc3

1 package built:
python37Packages.arviz

@jonringer jonringer merged commit 6cd6626 into NixOS:master Oct 11, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
python37Packages.arviz, python38Packages.arviz on aarch64-linux No attempt
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8fe9601"; rev="8fe9601f9f02b7ed1f8dc827d0d5fe7da4faeab6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8fe9601"; rev="8fe9601f9f02b7ed1f8dc827d0d5fe7da4faeab6"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8fe9601"; rev="8fe9601f9f02b7ed1f8dc827d0d5fe7da4faeab6"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8fe9601"; rev="8fe9601f9f02b7ed1f8dc827d0d5fe7da4faeab6"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8fe9601"; rev="8fe9601f9f02b7ed1f8dc827d0d5fe7da4faeab6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8fe9601"; rev="8fe9601f9f02b7ed1f8dc827d0d5fe7da4faeab6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8fe9601"; rev="8fe9601f9f02b7ed1f8dc827d0d5fe7da4faeab6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
python37Packages.arviz, python38Packages.arviz on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants