Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Isabelle with old Z3 #99503

Merged
merged 2 commits into from Oct 11, 2020
Merged

Build Isabelle with old Z3 #99503

merged 2 commits into from Oct 11, 2020

Conversation

@NieDzejkob
Copy link
Contributor

@NieDzejkob NieDzejkob commented Oct 3, 2020

Motivation for this change

Fixes #99399.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • Tested some of them
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
NieDzejkob added 2 commits Oct 3, 2020
Isabelle uses Z3 in a non-forwards-compatible manner, as it needs to
consume the proof objects Z3 produces. Building Isabelle with newer Z3
causes errors when trying to build a session that depends on
HOL-Library. Try

$ isabelle jedit -l HOL-Library

Fixes NixOS#99399.
@ofborg ofborg bot requested review from ttuegel and thoughtpolice Oct 3, 2020
@gebner gebner merged commit b03c6ef into NixOS:master Oct 11, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants