Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
haskell-language-server: Init wrapper for multiple ghc versions at 0.5.0 #99519
Motivation for this change
haskell-language-server needs a binary which is compiled with the ghc the user uses for their project. That's why hls normally get's distributed (e.g. via ghcup) with the haskell-language-server-wrapper that picks the right binary based on the current project and a binary for every supported ghc version.
I am introducing
I have fixed the closure size with reference-to. A glance at the binary made a reasonable impression that those references aren‘t needed. A quick test of the binary seems to do just fine.
cdepillabout left a comment
I don't use haskell-language-server, but this looks pretty good to me.
If I could make one suggestion, it would be to have some documentation in
For instance, if I was new to nixpkgs, my first thoughts would be:
I guess it would be nice to have this in the official documentation as well, but personally I'd be fine with just documenting it here in the code.
…5.0 (NixOS#99519) * haskell-language-server: Init wrapper for multiple ghc versions at 0.5.0 * Fix closure size * docs: Add hls section to Haskell part of manual