Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-edit: 0.6.0 -> 0.7.0 #99525

Merged
merged 1 commit into from Oct 4, 2020
Merged

cargo-edit: 0.6.0 -> 0.7.0 #99525

merged 1 commit into from Oct 4, 2020

Conversation

@kevincox
Copy link
Contributor

@kevincox kevincox commented Oct 4, 2020

Motivation for this change

Get the sort-by-default behaviour in the new version :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@kevincox kevincox requested a review from killercup Oct 4, 2020
@kevincox kevincox self-assigned this Oct 4, 2020
@kevincox
Copy link
Contributor Author

@kevincox kevincox commented Oct 4, 2020

maintiners: @Gerschtli @Gerschtli @jb55 @filalex77 @killercup

Copy link
Member

@killercup killercup left a comment

Thanks! Works great here on NixOS nightly :)

@kevincox kevincox merged commit b526796 into master Oct 4, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
cargo-edit, cargo-edit.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
cargo-edit, cargo-edit.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d5f158"; rev="8d5f158fe4a56d3d4cc36af1986b0027aaff704b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d5f158"; rev="8d5f158fe4a56d3d4cc36af1986b0027aaff704b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d5f158"; rev="8d5f158fe4a56d3d4cc36af1986b0027aaff704b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d5f158"; rev="8d5f158fe4a56d3d4cc36af1986b0027aaff704b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d5f158"; rev="8d5f158fe4a56d3d4cc36af1986b0027aaff704b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d5f158"; rev="8d5f158fe4a56d3d4cc36af1986b0027aaff704b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8d5f158"; rev="8d5f158fe4a56d3d4cc36af1986b0027aaff704b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@kevincox kevincox deleted the kevincox-cargo-edit branch Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.