Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

palemoon: 28.13.0 -> 28.14.2 #99536

Merged
merged 1 commit into from Oct 8, 2020

Conversation

@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Oct 4, 2020

Motivation for this change

Version bump. Also added wrapGAppsHook, assuming it will be needed once GTK3 support goes official-y, similar to FF.

Security issues fixed: CVE-2020-15676 and CVE-2020-15677

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 8, 2020

Is the mainstream pointing to use GTK3 in the future?

@OPNA2608
Copy link
Contributor Author

@OPNA2608 OPNA2608 commented Oct 8, 2020

Is the mainstream pointing to use GTK3 in the future?

There's a tracking issue for an officially sanctioned GTK3 build for the 29.0.0 milestone, the current official build instructions already contain switches for enabling it. The (current) plan for the official releases are:

Linux 32bit / EL 6 build env / GCC 4.9 / GTK 2.24 / Minimum glibc 2.12 / Ends November 30th, 2020
Current Linux 64bit (GTK2 Version) / EL 7 build env / GCC 7 or 8 / GTK 2.24 / Minimum glibc 2.17 / Ends June 30th, 2024
Future Linux 64bit GTK3 Version / EL 8 build env / GCC 8+ / GTK 3.22 / Minimum glibc 2.28 / Ends whenever EL 8 does

My plan was to switch our builds over to GCC8 and GTK3 once upstream ship an official GTK3 binary of their own, just to be safe. GTK2 is fine for me until then.

@AndersonTorres AndersonTorres merged commit e06c0fa into NixOS:master Oct 8, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
palemoon, palemoon.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="559cf21"; rev="559cf217d6a9074c5d93ec23c5234da349b2322f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="559cf21"; rev="559cf217d6a9074c5d93ec23c5234da349b2322f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="559cf21"; rev="559cf217d6a9074c5d93ec23c5234da349b2322f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="559cf21"; rev="559cf217d6a9074c5d93ec23c5234da349b2322f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="559cf21"; rev="559cf217d6a9074c5d93ec23c5234da349b2322f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="559cf21"; rev="559cf217d6a9074c5d93ec23c5234da349b2322f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="559cf21"; rev="559cf217d6a9074c5d93ec23c5234da349b2322f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
palemoon, palemoon.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.