Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphinx-intl: init at 2.0.1 #99544

Open
wants to merge 2 commits into
base: master
from
Open

sphinx-intl: init at 2.0.1 #99544

wants to merge 2 commits into from

Conversation

@EuAndreh
Copy link

@EuAndreh EuAndreh commented Oct 4, 2020

Motivation for this change

Add sphinx-intl package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Execution of binary tested with:

nix-shell -I nixpkgs=. -p 'python3.withPackages (p: [ p.sphinx-intl ])' --run sphinx-intl
@EuAndreh EuAndreh requested review from FRidh and jonringer as code owners Oct 4, 2020
@EuAndreh EuAndreh force-pushed the EuAndreh:sphinx-intl branch 3 times, most recently from 22e548f to 1390ef9 Oct 4, 2020
@ofborg ofborg bot added the 6.topic: python label Oct 4, 2020
@EuAndreh EuAndreh force-pushed the EuAndreh:sphinx-intl branch from 1390ef9 to 204f909 Oct 4, 2020
Copy link
Contributor

@IvarWithoutBones IvarWithoutBones left a comment

Just 2 minor nits, otherwise LGTM 👍

Also, merge conflict in pkgs/top-level/python-packages.nix should be fixed.

maintainers/maintainer-list.nix Show resolved Hide resolved
@EuAndreh
Copy link
Author

@EuAndreh EuAndreh commented Oct 8, 2020

@EuAndreh EuAndreh force-pushed the EuAndreh:sphinx-intl branch from 204f909 to 323ea45 Oct 8, 2020
@EuAndreh
Copy link
Author

@EuAndreh EuAndreh commented Oct 8, 2020

@EuAndreh EuAndreh force-pushed the EuAndreh:sphinx-intl branch from 323ea45 to e66747c Oct 8, 2020
@EuAndreh EuAndreh force-pushed the EuAndreh:sphinx-intl branch from e66747c to ea3d272 Oct 8, 2020
@EuAndreh
Copy link
Author

@EuAndreh EuAndreh commented Oct 8, 2020

@EuAndreh EuAndreh force-pushed the EuAndreh:sphinx-intl branch from ea3d272 to 3e6b4d6 Nov 3, 2020
@EuAndreh EuAndreh mentioned this pull request Nov 3, 2020
4 of 10 tasks complete
@EuAndreh EuAndreh force-pushed the EuAndreh:sphinx-intl branch 2 times, most recently from fb0e180 to c7c0603 Nov 3, 2020

buildPythonPackage rec {
pname = "sphinx-intl";
version = "2.0.1";

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 25, 2020
Contributor

Please disable it before Python 3.5:

ERROR: Package 'sphinx-intl' requires a different Python: 2.7.18 not in '>=3.5'
sha256 = "1d1q0sanjp4nkfvhsxi75zf3xjyyi8nzxvl3v7l0jy9ld70nwnmj";
};

propagatedBuildInputs = [ Babel click sphinx ];

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 25, 2020
Contributor

Please disable tests or fetch from GitHub where maybe tests are included:

writing manifest file 'sphinx_intl.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 26, 2020
Contributor

# package does not contain any tests
doChecks = false;
@SuperSandro2000
Copy link
Contributor

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Result of nixpkgs-review pr 99544 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python27Packages.sphinx-intl
2 packages built:
  • python37Packages.sphinx-intl
  • python38Packages.sphinx-intl
@EuAndreh EuAndreh force-pushed the EuAndreh:sphinx-intl branch 2 times, most recently from 96e7b8d to a81bfa2 Nov 25, 2020
@EuAndreh
Copy link
Author

@EuAndreh EuAndreh commented Nov 25, 2020

@EuAndreh EuAndreh requested a review from SuperSandro2000 Nov 25, 2020
sha256 = "1d1q0sanjp4nkfvhsxi75zf3xjyyi8nzxvl3v7l0jy9ld70nwnmj";
};

propagatedBuildInputs = [ Babel click sphinx ];

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 26, 2020
Contributor

# package does not contain any tests
doChecks = false;
@EuAndreh EuAndreh force-pushed the EuAndreh:sphinx-intl branch from a81bfa2 to 20d63eb Nov 26, 2020
@EuAndreh
Copy link
Author

@EuAndreh EuAndreh commented Nov 26, 2020

@EuAndreh
Copy link
Author

@EuAndreh EuAndreh commented Nov 26, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.