Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] gomplate: init at 3.8.0 #99548

Merged
merged 1 commit into from Oct 4, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 4, 2020

Motivation for this change

Backport of #99402

Yes, this is me trying to sneak a new package into the soon-to-be-stable branch post freeze, but in my defence, it's a leaf package and shouldn't affect anything else.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
(cherry picked from commit d451ecb)
Copy link
Member

@davidak davidak left a comment

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64
  • executables tested on x86_64
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch
Possible improvements

Can you add meta.platforms? Or does it come from buildGoModule?

Comments

Except that, looks good

@risicle
Copy link
Contributor Author

@risicle risicle commented Oct 4, 2020

I would have if asked on master, but this is just a backport and it doesn't seem worth diverging the branches for...

@davidak
Copy link
Member

@davidak davidak commented Oct 4, 2020

yes, it has to be added on master first. maybe in another pr

@davidak
davidak approved these changes Oct 4, 2020
@aanderse
Copy link
Contributor

@aanderse aanderse commented Oct 4, 2020

I don't think you need to declare platforms for go packages because it inherits... maybe? Someone should verify that.

@risicle it's perfectly acceptable to backport leaf packages like this during a release. There isn't any impact, like you said.

@risicle risicle merged commit 54e4fdf into NixOS:release-20.09 Oct 4, 2020
18 checks passed
18 checks passed
action
Details
gomplate, gomplate.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
gomplate, gomplate.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff2e0ca"; rev="ff2e0ca52d25406e48e14620ec46f4f0d288da03"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff2e0ca"; rev="ff2e0ca52d25406e48e14620ec46f4f0d288da03"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff2e0ca"; rev="ff2e0ca52d25406e48e14620ec46f4f0d288da03"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff2e0ca"; rev="ff2e0ca52d25406e48e14620ec46f4f0d288da03"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff2e0ca"; rev="ff2e0ca52d25406e48e14620ec46f4f0d288da03"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff2e0ca"; rev="ff2e0ca52d25406e48e14620ec46f4f0d288da03"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ff2e0ca"; rev="ff2e0ca52d25406e48e14620ec46f4f0d288da03"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.