Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jwm: fix gettext requirement #99554

Merged
merged 1 commit into from Oct 4, 2020
Merged

jwm: fix gettext requirement #99554

merged 1 commit into from Oct 4, 2020

Conversation

@jmpunkt
Copy link
Contributor

@jmpunkt jmpunkt commented Oct 4, 2020

Jwm requests a specific version of gettext. Since the current version
of gettext is higher, the build fails. Gettext supports to request
a minimum version (since 0.19.6). A patch is introduces which requests
the minimum version 0.19.6.

Motivation for this change

Jwm currently fails on master and 20.09, due to gettext versions conflicts.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Jwm requests a specific version of gettext. Since the current version
of gettext is higher, the build fails. Gettext supports to request
a minimum version (since 0.19.6). A patch is introduces which requests
the minimum version 0.19.6.
@romildo
romildo approved these changes Oct 4, 2020
Copy link
Contributor

@romildo romildo left a comment

Tested on a VM. LGTM.

@romildo romildo merged commit 788d609 into NixOS:master Oct 4, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
jwm, jwm.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1a22a73"; rev="1a22a73ddeedd6982ade96d56758df3f6e0cf626"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1a22a73"; rev="1a22a73ddeedd6982ade96d56758df3f6e0cf626"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1a22a73"; rev="1a22a73ddeedd6982ade96d56758df3f6e0cf626"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1a22a73"; rev="1a22a73ddeedd6982ade96d56758df3f6e0cf626"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1a22a73"; rev="1a22a73ddeedd6982ade96d56758df3f6e0cf626"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1a22a73"; rev="1a22a73ddeedd6982ade96d56758df3f6e0cf626"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1a22a73"; rev="1a22a73ddeedd6982ade96d56758df3f6e0cf626"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
jwm, jwm.passthru.tests on x86_64-linux Success
Details
@jmpunkt jmpunkt mentioned this pull request Oct 5, 2020
2 of 10 tasks complete
@jmpunkt jmpunkt deleted the jmpunkt:jwm-gettext-fix branch Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.