Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enlightenment.efl: enable wayland client support #99556

Merged
merged 4 commits into from Oct 11, 2020
Merged

Conversation

@romildo
Copy link
Contributor

@romildo romildo commented Oct 4, 2020

Motivation for this change

enlightenment.efl: enable wayland client support
enlightenment.efl: use pkg-config instead of the alias pkgconfig
enlightenment.efl: fix license
enlightenment.efl: remove leftover patch file

Fixes #98659

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@romildo romildo requested review from matejc and ftrvxmtrx Oct 4, 2020
@romildo romildo force-pushed the romildo:upd.efl branch 2 times, most recently from 55d33a7 to 97ee4eb Oct 4, 2020
@romildo romildo force-pushed the romildo:upd.efl branch from 97ee4eb to c98d83b Oct 5, 2020
@romildo
Copy link
Contributor Author

@romildo romildo commented Oct 5, 2020

Result of nixpkgs-review pr 99556 1

10 packages built:
  • enlightenment.econnman
  • enlightenment.efl
  • enlightenment.enlightenment
  • enlightenment.ephoto
  • enlightenment.evisum
  • enlightenment.rage
  • enlightenment.terminology
  • python27Packages.pythonefl
  • python37Packages.pythonefl
  • python38Packages.pythonefl
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 6, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/322

@romildo romildo requested a review from worldofpeace Oct 10, 2020
@worldofpeace worldofpeace merged commit f93d9fe into NixOS:master Oct 11, 2020
19 of 20 checks passed
19 of 20 checks passed
tests tests
Details
action
Details
enlightenment.efl, enlightenment.efl.passthru.tests on x86_64-darwin
Details
enlightenment.efl, enlightenment.efl.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
enlightenment.efl, enlightenment.efl.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c98d83b"; rev="c98d83b15ca2aa9baae86653d98d8cb14dceac5b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c98d83b"; rev="c98d83b15ca2aa9baae86653d98d8cb14dceac5b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c98d83b"; rev="c98d83b15ca2aa9baae86653d98d8cb14dceac5b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c98d83b"; rev="c98d83b15ca2aa9baae86653d98d8cb14dceac5b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c98d83b"; rev="c98d83b15ca2aa9baae86653d98d8cb14dceac5b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c98d83b"; rev="c98d83b15ca2aa9baae86653d98d8cb14dceac5b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c98d83b"; rev="c98d83b15ca2aa9baae86653d98d8cb14dceac5b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Oct 11, 2020

I'm half expecting some sort of change in the nixos module?

@romildo
Copy link
Contributor Author

@romildo romildo commented Oct 11, 2020

@worldofpeace , thank you for reviewing and merging this PR.

I'm half expecting some sort of change in the nixos module?

Do you mean changes in the nixos module related to wayland?

This PR does not enable running the Enlightenment DE on wayland yet. It just enables running EFL applications (like terminology) on any DE on wayland, like sway.

@romildo romildo deleted the romildo:upd.efl branch Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.