Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] python.pkgs.fontforge: disable with Python 2 #99558

merged 2 commits into from Oct 4, 2020


Copy link

@erictapen erictapen commented Oct 4, 2020

Motivation for this change

Addresses #98475.

Things done

Backport #93674, as the problem of fontforge lacking python2 bindings also applies to nixos-20.03.

Also I patched monoid with #93674 to make it build again. Afaict this is the only remaining package using python2Packages.fontforge.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
jtojnar and others added 2 commits Oct 4, 2020
Since the latest update, fontforge no longer supports building with Python 2. Let's prevent failing builds.

(cherry picked from commit ce55b09)
Also applied a patch, so we can build with python3Packages.fontforge, as
fontforge doesn't have python2 bindings anymore.
romildo approved these changes Oct 4, 2020
Copy link

@romildo romildo left a comment


@erictapen erictapen merged commit 0d0660f into NixOS:release-20.03 Oct 4, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants