Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nzbhydra2 #99559

Open
wants to merge 2 commits into
base: master
from
Open

Nzbhydra2 #99559

wants to merge 2 commits into from

Conversation

@JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee commented Oct 4, 2020

Motivation for this change

Closes #76878

Use the AUR package and jackett.nix as guidance on how to package NZBHydra2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@aanderse aanderse left a comment

The service is looking good. I have left a few comments that I think would improve it. I hope you find my comments helpful.

I generally only review modules, not packages, so we'll need to have someone review the package as well.

nixos/modules/services/misc/nzbhydra2.nix Outdated Show resolved Hide resolved
nixos/modules/misc/ids.nix Outdated Show resolved Hide resolved
@JamieMagee JamieMagee requested a review from aanderse Oct 7, 2020
@JamieMagee JamieMagee force-pushed the JamieMagee:nzbhydra2 branch from daaea23 to e89a43e Oct 7, 2020
Copy link
Contributor

@aanderse aanderse left a comment

I approve of the module.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 21, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/345

url =
"https://github.com/theotherp/${pname}/releases/download/v${version}/${pname}-${version}-linux.zip";
Comment on lines +8 to +9

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 27, 2020
Contributor

Suggested change
url =
"https://github.com/theotherp/${pname}/releases/download/v${version}/${pname}-${version}-linux.zip";
url = "https://github.com/theotherp/${pname}/releases/download/v${version}/${pname}-${version}-linux.zip";
sha512 =
"11rl2q8fm2acpwjsadkjz58prp66n29dr5lc5qgv494y1s63qxybzkgj53yzaywlrs530x3gv7rwkvjy85bz8clhr5lfcw9kp49s7gv";
Comment on lines +10 to +11

This comment has been minimized.

@SuperSandro2000

SuperSandro2000 Nov 27, 2020
Contributor

Suggested change
sha512 =
"11rl2q8fm2acpwjsadkjz58prp66n29dr5lc5qgv494y1s63qxybzkgj53yzaywlrs530x3gv7rwkvjy85bz8clhr5lfcw9kp49s7gv";
sha512 = "11rl2q8fm2acpwjsadkjz58prp66n29dr5lc5qgv494y1s63qxybzkgj53yzaywlrs530x3gv7rwkvjy85bz8clhr5lfcw9kp49s7gv";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.