Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nzbhydra2: init at 3.8.0 #99559

Merged
merged 2 commits into from Jan 9, 2021
Merged

nzbhydra2: init at 3.8.0 #99559

merged 2 commits into from Jan 9, 2021

Conversation

@JamieMagee
Copy link
Member

@JamieMagee JamieMagee commented Oct 4, 2020

Motivation for this change

Closes #76878

Use the AUR package and jackett.nix as guidance on how to package NZBHydra2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@aanderse aanderse left a comment

The service is looking good. I have left a few comments that I think would improve it. I hope you find my comments helpful.

I generally only review modules, not packages, so we'll need to have someone review the package as well.

nixos/modules/services/misc/nzbhydra2.nix Outdated Show resolved Hide resolved
nixos/modules/misc/ids.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/nzbhydra2.nix Show resolved Hide resolved
Copy link
Member

@aanderse aanderse left a comment

I approve of the module.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 21, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/345

pkgs/servers/nzbhydra2/default.nix Outdated Show resolved Hide resolved
pkgs/servers/nzbhydra2/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 8, 2020

@JamieMagee Please resolve the merge conflcit.

@JamieMagee
Copy link
Member Author

@JamieMagee JamieMagee commented Dec 21, 2020

@SuperSandro2000 Ready for review

@JamieMagee
Copy link
Member Author

@JamieMagee JamieMagee commented Dec 21, 2020

Pushed an update from 2.29.1 to 3.8.0.

@aanderse I had to remove the MemoryDenyWriteExecute = true; in order to get OpenJDK to run. Otherwise it would fail with

OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x00007f9e8b2c3000, 2555904, 1) failed; error='Operation not permitted' (errno=1)

@JamieMagee
Copy link
Member Author

@JamieMagee JamieMagee commented Dec 29, 2020

@ofborg eval

@JamieMagee JamieMagee requested a review from SuperSandro2000 Dec 29, 2020
@aanderse
Copy link
Member

@aanderse aanderse commented Jan 3, 2021

@SuperSandro2000 I propose merge - any outstanding issues from your point of view?

@JamieMagee
Copy link
Member Author

@JamieMagee JamieMagee commented Jan 9, 2021

@aanderse It appears there are no concerns?

@aanderse
Copy link
Member

@aanderse aanderse commented Jan 9, 2021

@JamieMagee sure. I'll assume @SuperSandro2000 is good with the package and merge once the bot runs your test.

Thanks for contributing to nixpkgs!

@GrahamcOfBorg test nzbhydra2

@aanderse aanderse changed the title Nzbhydra2 nzbhydra2: init at 3.8.0 Jan 9, 2021
@aanderse aanderse merged commit 4b0a2ac into NixOS:master Jan 9, 2021
21 checks passed
@JamieMagee JamieMagee deleted the nzbhydra2 branch Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants