Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monoid: 2016-07-21 -> 2018-06-03, use python3 #99561

Merged
merged 1 commit into from Oct 4, 2020

Conversation

@erictapen
Copy link
Contributor

@erictapen erictapen commented Oct 4, 2020

Motivation for this change

monoid is broken, as fontforge doesn't supply python2 bindings anymore.

Also address #98475.

Things done

Bumped version, applied larsenwork/monoid#233, use python3Packages.fontforge.

This needs to be backported to nixos-20.09. For nixos-20.03 see #99558.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Also pinging @romildo as the maintainer of the package.

Also applied a patch, so we can build with python3Packages.fontforge, as
fontforge doesn't have python2 bindings anymore.
@romildo
romildo approved these changes Oct 4, 2020
Copy link
Contributor

@romildo romildo left a comment

LGTM

@erictapen erictapen merged commit 73eeb77 into NixOS:master Oct 4, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
monoid, monoid.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6b8503"; rev="b6b8503f857aee5ff6b9f21c1c28d478b842dbe1"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6b8503"; rev="b6b8503f857aee5ff6b9f21c1c28d478b842dbe1"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6b8503"; rev="b6b8503f857aee5ff6b9f21c1c28d478b842dbe1"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6b8503"; rev="b6b8503f857aee5ff6b9f21c1c28d478b842dbe1"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6b8503"; rev="b6b8503f857aee5ff6b9f21c1c28d478b842dbe1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6b8503"; rev="b6b8503f857aee5ff6b9f21c1c28d478b842dbe1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6b8503"; rev="b6b8503f857aee5ff6b9f21c1c28d478b842dbe1"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
monoid, monoid.passthru.tests on x86_64-linux Success
Details
@erictapen
Copy link
Contributor Author

@erictapen erictapen commented Oct 4, 2020

backport to 20.09 in 77660fc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.