Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] nixpkgs-review: 2.4.0 -> 2.4.1 -> 2.4.2 #99566

Merged
merged 2 commits into from Oct 4, 2020

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 4, 2020

Motivation for this change

Backport nixpkgs-review updates per request from @Mic92
#99481 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
jonringer added 2 commits Sep 28, 2020
(cherry picked from commit 6d812f2)
(cherry picked from commit a51c51c)
@mweinelt mweinelt requested a review from jonringer Oct 4, 2020
@mweinelt
Copy link
Member Author

@mweinelt mweinelt commented Oct 4, 2020

Result of nixpkgs-review pr 99566 1

1 package built:
  • nix-review (nixpkgs-review)
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 99566 1

1 package built:
  • nix-review (nixpkgs-review)

@jonringer jonringer merged commit 27fcfaa into NixOS:release-20.09 Oct 4, 2020
1 of 2 checks passed
1 of 2 checks passed
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
@mweinelt mweinelt deleted the mweinelt:20.09/nixpkgs-review branch Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.