Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "python3Packages.localzone: Use dnspython_1" #99567

wants to merge 1 commit into from


Copy link

@FRidh FRidh commented Oct 4, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Using a different version of a package in `python-packages.nix` is not allowed
because this can lead to multiple versions in a closure, which Python
cannot deal with.

This reverts commit 7a85f34.
Copy link

@mweinelt mweinelt commented Oct 4, 2020

Can you pick 198f2da?

@FRidh FRidh closed this Oct 4, 2020
Copy link
Member Author

@FRidh FRidh commented Oct 4, 2020

Copy link

@jonringer jonringer commented Oct 4, 2020

I already made an issue upstream ags-slc/localzone#1

Copy link

@ags-slc ags-slc commented Oct 6, 2020

Thanks again for reporting this issue @jonringer. The latest release should now support dnspython >= 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants