Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.localzone: revert dnspython downgrade and mark as broken #99568

Merged
merged 2 commits into from Oct 4, 2020

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 4, 2020

Motivation for this change

#99496 (review)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
mweinelt added 2 commits Oct 4, 2020
…ngrade"

This reverts commit 1d122a8, reversing
changes made to 4304c70.

Quoting FRidh:
> Libraries cannot use a different version. If it is not compatible with the
> current dnspython it needs to be marked as broken.
@mweinelt mweinelt requested review from fadenb and FRidh Oct 4, 2020
@mweinelt mweinelt requested a review from jonringer as a code owner Oct 4, 2020
@FRidh FRidh mentioned this pull request Oct 4, 2020
0 of 10 tasks complete
@FRidh
FRidh approved these changes Oct 4, 2020
@mweinelt
Copy link
Member Author

@mweinelt mweinelt commented Oct 4, 2020

What about removing the dnspython_1 alias which you proposed shortly in #99567?

Edit: Ah, used by electrum.

@FRidh
Copy link
Member

@FRidh FRidh commented Oct 4, 2020

I removed that because, while it prevents people from using it in python-packages.nix, it is there for a reason, like many other _<version> attributes.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 4, 2020

This is the proper course of action until ags-slc/localzone#1 gets resolved

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

I'll create another PR fixing lexicon

https://github.com/NixOS/nixpkgs/pull/99568
4 packages marked as broken and skipped:
ape lexicon python37Packages.localzone python38Packages.localzone
@jonringer jonringer merged commit e1a47f2 into NixOS:master Oct 4, 2020
2 of 3 checks passed
2 of 3 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
@mweinelt mweinelt deleted the mweinelt:revert-localzone branch Oct 4, 2020
@jonringer jonringer mentioned this pull request Oct 4, 2020
5 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.