Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lexicon: fix build, ape: fix inheritance #99571

Merged
merged 3 commits into from Oct 5, 2020
Merged

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 4, 2020

Motivation for this change

follow up to: #99568

created a python packages overlay for lexicon.
bumped lexicon

fixed ape from inheriting the lexicon attr from pkgs scope.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/99571
2 packages built:
ape lexicon
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 4, 2020

I ran ofborg checkMeta locally:

[09:06:42] jon@nixos ~/projects/nixpkgs (fix-lexicon)
$ GC_INITIAL_HEAP_SIZE=16g nix-env -f ./outpaths.nix -qaP --no-name --out-path --arg checkMeta true > out-paths
[09:09:37] jon@nixos ~/projects/nixpkgs (fix-lexicon)

NOTE: takes >=20GB of RAM to execute that now

jonringer added 3 commits Oct 4, 2020
@jonringer jonringer force-pushed the jonringer:fix-lexicon branch from e3e49e0 to 2e9e2a1 Oct 4, 2020
@jonringer jonringer changed the title Fix lexicon lexicon: fix build, ape: fix inheritance Oct 4, 2020
@jonringer jonringer mentioned this pull request Oct 4, 2020
5 of 10 tasks complete
@ofborg ofborg bot requested a review from yrashk Oct 4, 2020
@jonringer jonringer merged commit 90e5082 into NixOS:master Oct 5, 2020
19 of 20 checks passed
19 of 20 checks passed
tests tests
Details
action
Details
ape, ape.passthru.tests, lexicon, lexicon.passthru.tests on x86_64-darwin
Details
ape, ape.passthru.tests, lexicon, lexicon.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
ape, ape.passthru.tests, lexicon, lexicon.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e9e2a1"; rev="2e9e2a181536b5d132a0082bee70f844dc627584"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e9e2a1"; rev="2e9e2a181536b5d132a0082bee70f844dc627584"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e9e2a1"; rev="2e9e2a181536b5d132a0082bee70f844dc627584"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e9e2a1"; rev="2e9e2a181536b5d132a0082bee70f844dc627584"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e9e2a1"; rev="2e9e2a181536b5d132a0082bee70f844dc627584"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e9e2a1"; rev="2e9e2a181536b5d132a0082bee70f844dc627584"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2e9e2a1"; rev="2e9e2a181536b5d132a0082bee70f844dc627584"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer jonringer deleted the jonringer:fix-lexicon branch Oct 6, 2020
@jonringer jonringer mentioned this pull request Oct 6, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.