Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kitty: 0.18.3 -> 0.19.0 #99577

Merged
merged 2 commits into from Oct 5, 2020
Merged

kitty: 0.18.3 -> 0.19.0 #99577

merged 2 commits into from Oct 5, 2020

Conversation

@Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Oct 4, 2020

Motivation for this change

https://github.com/kovidgoyal/kitty/releases/tag/v0.19.0

This release requires a new dependency.
There is now a flag for the build system to disable LTO. This removes the need for a patch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Luflosi added 2 commits Oct 4, 2020
The `strictoverflow` hardening feature causes a build failure when using Clang as the compiler, not just on Darwin.
https://github.com/kovidgoyal/kitty/releases/tag/v0.19.0

This release requires a new dependency.
There is now a flag for the build system to disable LTO. This removes the need for a patch.
Copy link
Contributor

@hugolgst hugolgst left a comment

Looks good to me.

Result of nixpkgs-review pr 99577

1 package built:
kitty
@danieldk danieldk merged commit f4e6fec into NixOS:master Oct 5, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
kitty, kitty.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5359c18"; rev="5359c185d8411028796f3f9e78f26da2f6203320"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5359c18"; rev="5359c185d8411028796f3f9e78f26da2f6203320"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5359c18"; rev="5359c185d8411028796f3f9e78f26da2f6203320"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5359c18"; rev="5359c185d8411028796f3f9e78f26da2f6203320"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5359c18"; rev="5359c185d8411028796f3f9e78f26da2f6203320"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5359c18"; rev="5359c185d8411028796f3f9e78f26da2f6203320"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5359c18"; rev="5359c185d8411028796f3f9e78f26da2f6203320"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kitty, kitty.passthru.tests on x86_64-linux Success
Details
@Luflosi Luflosi deleted the Luflosi:update/kitty branch Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.