Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bmon: fix cross-compilation #99580

Merged
merged 1 commit into from Oct 11, 2020
Merged

bmon: fix cross-compilation #99580

merged 1 commit into from Oct 11, 2020

Conversation

@lopsided98
Copy link
Contributor

@lopsided98 lopsided98 commented Oct 4, 2020

Motivation for this change

PKG_CONFIG must be an absolute path, otherwise the build fails with the following error:

configure: error: 
      *** The pkg-config script could not be found. Make sure it is
      *** in your path, or set the PKG_CONFIG environment variable
      *** to the full path to pkg-config.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @bjornfor @pSub

@lopsided98
Copy link
Contributor Author

@lopsided98 lopsided98 commented Oct 4, 2020

@ofborg build pkgsCross.armv7l-hf-multiplatform.bmon

Copy link
Contributor

@bjornfor bjornfor left a comment

Nit: could use command -v instead of type -p, for portability?

$PKG_CONFIG must be an absolute path
@lopsided98
Copy link
Contributor Author

@lopsided98 lopsided98 commented Oct 5, 2020

Ok, done.

@lopsided98 lopsided98 force-pushed the lopsided98:bmon-cross branch from 96910ff to ba4a9ef Oct 5, 2020
@ofborg ofborg bot requested a review from bjornfor Oct 5, 2020
@bjornfor bjornfor merged commit 0c97fff into NixOS:master Oct 11, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
bmon, bmon.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
bmon, bmon.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ba4a9ef"; rev="ba4a9ef74227348b52537ed818a3e9f138dd6120"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ba4a9ef"; rev="ba4a9ef74227348b52537ed818a3e9f138dd6120"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ba4a9ef"; rev="ba4a9ef74227348b52537ed818a3e9f138dd6120"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ba4a9ef"; rev="ba4a9ef74227348b52537ed818a3e9f138dd6120"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ba4a9ef"; rev="ba4a9ef74227348b52537ed818a3e9f138dd6120"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ba4a9ef"; rev="ba4a9ef74227348b52537ed818a3e9f138dd6120"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ba4a9ef"; rev="ba4a9ef74227348b52537ed818a3e9f138dd6120"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@lopsided98 lopsided98 deleted the lopsided98:bmon-cross branch Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.