Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lm_sensors: fix cross-compilation #99583

Merged
merged 1 commit into from Oct 8, 2020
Merged

Conversation

@lopsided98
Copy link
Contributor

@lopsided98 lopsided98 commented Oct 4, 2020

Motivation for this change

CC and AR need to be specified for cross-compilation to work.

@ofborg build pkgsCross.armv7l-hf-multiplatform.lm_sensors lm_sensors

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @dtzWill @Ericson2314

@lopsided98
Copy link
Contributor Author

@lopsided98 lopsided98 commented Oct 6, 2020

@ofborg build pkgsCross.armv7l-hf-multiplatform.lm_sensors

@lopsided98 lopsided98 force-pushed the lopsided98:lm-sensors-cross branch from 71b2e89 to cba24b4 Oct 8, 2020
@lopsided98
Copy link
Contributor Author

@lopsided98 lopsided98 commented Oct 8, 2020

@ofborg build pkgsCross.armv7l-hf-multiplatform.lm_sensors

@Ericson2314 Ericson2314 merged commit e4538ab into NixOS:master Oct 8, 2020
21 checks passed
21 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cba24b4"; rev="cba24b487e3b89ec029a18e86794e0ce829cae55"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cba24b4"; rev="cba24b487e3b89ec029a18e86794e0ce829cae55"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cba24b4"; rev="cba24b487e3b89ec029a18e86794e0ce829cae55"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cba24b4"; rev="cba24b487e3b89ec029a18e86794e0ce829cae55"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cba24b4"; rev="cba24b487e3b89ec029a18e86794e0ce829cae55"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cba24b4"; rev="cba24b487e3b89ec029a18e86794e0ce829cae55"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cba24b4"; rev="cba24b487e3b89ec029a18e86794e0ce829cae55"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
lm_sensors, lm_sensors.passthru.tests on aarch64-linux Success
Details
lm_sensors, lm_sensors.passthru.tests on x86_64-linux Success
Details
pkgsCross.armv7l-hf-multiplatform.lm_sensors on aarch64-linux Success
Details
pkgsCross.armv7l-hf-multiplatform.lm_sensors on x86_64-linux Success
Details
@lopsided98 lopsided98 deleted the lopsided98:lm-sensors-cross branch Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.