Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.python-miio: fix build #99585

Closed
wants to merge 2 commits into from

Conversation

@georgewhewell
Copy link
Contributor

@georgewhewell georgewhewell commented Oct 4, 2020

Motivation for this change

python-miio does not build-

ERROR: No matching distribution found for pytz<2020.0,>=2019.3 (from python-miio==0.5.3)
Things done

patch setup.py so any version is allowed
add some new dependencies
remove failing (broken?) test

testing:

  • remaining tests pass on python3.8

  • exeutables seem to function correctly

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

@georgewhewell georgewhewell force-pushed the georgewhewell:fix-python-miio branch from 0a0783f to 1a84a57 Oct 4, 2020
Co-authored-by: Jon <jonringer@users.noreply.github.com>
@georgewhewell georgewhewell force-pushed the georgewhewell:fix-python-miio branch from 1a84a57 to 8944bc6 Oct 4, 2020
@georgewhewell
Copy link
Contributor Author

@georgewhewell georgewhewell commented Oct 4, 2020

@jonringer thanks, applied and rebased

Co-authored-by: Jon <jonringer@users.noreply.github.com>
@georgewhewell
Copy link
Contributor Author

@georgewhewell georgewhewell commented Oct 5, 2020

@jonringer importlib_metadata seems to be required on python 3.8:

Traceback (most recent call last):
  File "/nix/store/2xaplvp6mhnmacxx1z0xcxrn361mbc36-python3.8-python-miio-0.5.3/bin/.mirobo-wrapped", line 6, in <module>
    from miio.vacuum_cli import cli
  File "/nix/store/2xaplvp6mhnmacxx1z0xcxrn361mbc36-python3.8-python-miio-0.5.3/lib/python3.8/site-packages/miio/__init__.py", line 2, in <module>
    from importlib_metadata import version  # type: ignore
ModuleNotFoundError: No module named 'importlib_metadata'
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 5, 2020

then upstream incorrectly packaged it, it's part of the standard library, and only should be backported to unsupported python versions

@georgewhewell
Copy link
Contributor Author

@georgewhewell georgewhewell commented Nov 21, 2020

superseded by #102183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.