Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.wxPython: fix build on darwin #99586

Merged
merged 1 commit into from Oct 12, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 4, 2020

Motivation for this change

ZHF: #97479

I don't know why I have to do all the manual framework inclusion through NIX_CFLAGS_COMPILE - surely this should be done at a higher level. Perhaps someone with more macos nous can tell me how to do this more elegantly...

Reverse dependency plover still fails to build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@r-burns
Copy link
Contributor

@r-burns r-burns commented Oct 4, 2020

Yeah that is odd with the cflags. Also, why are those frameworks in nativeBuildInputs rather than buildInputs?

macos 10.14:
Result of nixpkgs-review pr 99586 1

7 packages marked as broken and skipped:
  • gnuradio
  • gnuradio-with-packages
  • gr-ais
  • gr-nacl
  • gr-osmosdr
  • gr-rds
  • grass
3 packages failed to build:
  • plover.stable
  • python27Packages.runsnakerun
  • python27Packages.squaremap
3 packages built:
  • python27Packages.wxPython (python27Packages.wxPython30)
  • torchat
  • winpdb
@risicle
Copy link
Contributor Author

@risicle risicle commented Oct 4, 2020

🤷 🤷 🤷 🤷 🤷 🤷 🤷 🤷 🤷 🤷 🤷 🤷

I mean, it does seem to actually work with at least one downstream app (winpdb).

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 11, 2020

@LnL7 what's the practice for darwin frameworks? I'm assuming the should be in buildInputs as they will likely need to be linked against.

@LnL7
Copy link
Member

@LnL7 LnL7 commented Oct 11, 2020

Indeed frameworks are just libraries with some extra stuff. Framework flags are also setup automatically, but that is most likely skipped because it's they are native inputs here.

pkgs/development/python-modules/wxPython/3.0.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/wxPython/3.0.nix Outdated Show resolved Hide resolved
@risicle risicle force-pushed the risicle:ris-wxpython-darwin-fix branch from f3bc893 to b8dc969 Oct 11, 2020
@risicle risicle force-pushed the risicle:ris-wxpython-darwin-fix branch from b8dc969 to 3382ea4 Oct 11, 2020
@risicle risicle requested a review from LnL7 Oct 11, 2020
@LnL7
LnL7 approved these changes Oct 11, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 99586 1

@jonringer jonringer merged commit 49b4cd5 into NixOS:master Oct 12, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3382ea4"; rev="3382ea4aca69b9f5ec85ac6806c566fc0ac3d533"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3382ea4"; rev="3382ea4aca69b9f5ec85ac6806c566fc0ac3d533"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3382ea4"; rev="3382ea4aca69b9f5ec85ac6806c566fc0ac3d533"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3382ea4"; rev="3382ea4aca69b9f5ec85ac6806c566fc0ac3d533"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3382ea4"; rev="3382ea4aca69b9f5ec85ac6806c566fc0ac3d533"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3382ea4"; rev="3382ea4aca69b9f5ec85ac6806c566fc0ac3d533"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3382ea4"; rev="3382ea4aca69b9f5ec85ac6806c566fc0ac3d533"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@risicle risicle mentioned this pull request Oct 12, 2020
2 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.