Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pymc3: fix build, init pythonPackages.fastprogress at 1.0.0 #99587

Merged
merged 2 commits into from Oct 18, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 4, 2020

Motivation for this change

ZHF: #97479

This has to wait on both:

  • getting Theano fixed and working again, either by #99516 or other means
  • getting arviz building again: #99500

Includes new dependency fastprogress.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@risicle
Copy link
Contributor Author

@risicle risicle commented Oct 16, 2020

@ofborg build python37Packages.pymc3

@risicle risicle force-pushed the risicle:ris-pymc3-fix branch from 59ce1f3 to b2d7f8d Oct 17, 2020
@risicle risicle marked this pull request as ready for review Oct 17, 2020
@risicle risicle requested review from FRidh and jonringer as code owners Oct 17, 2020
@risicle
Copy link
Contributor Author

@risicle risicle commented Oct 17, 2020

This is a fun situation - the issues holding up this PR have been resolved, but in that time, the dependency tensorflow has been broken in master. So testing this PR is difficult. But the reason I actually want it merged is because I need to backport it to 20.09, where it will be able to actually fix pymc3. I promise.

So, seeing as pymc3 was previously broken anyway, I wonder if anyone would find it in their hearts to "just trust me".

@jonringer jonringer merged commit 3c3295a into NixOS:master Oct 18, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
python37Packages.pymc3 on aarch64-linux Failure
Details
python37Packages.pymc3 on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b2d7f8d"; rev="b2d7f8dc1ba16018ca9b647c0cab762fa924154c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b2d7f8d"; rev="b2d7f8dc1ba16018ca9b647c0cab762fa924154c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b2d7f8d"; rev="b2d7f8dc1ba16018ca9b647c0cab762fa924154c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b2d7f8d"; rev="b2d7f8dc1ba16018ca9b647c0cab762fa924154c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b2d7f8d"; rev="b2d7f8dc1ba16018ca9b647c0cab762fa924154c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b2d7f8d"; rev="b2d7f8dc1ba16018ca9b647c0cab762fa924154c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b2d7f8d"; rev="b2d7f8dc1ba16018ca9b647c0cab762fa924154c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 18, 2020

i think it's fine. it's still an improvement, just because tensorflow likes to die every other week shouldn't keep this from also being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.