Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logtop: init at 0.7 #99593

Merged
merged 2 commits into from Oct 6, 2020
Merged

logtop: init at 0.7 #99593

merged 2 commits into from Oct 6, 2020

Conversation

@starcraft66
Copy link
Contributor

@starcraft66 starcraft66 commented Oct 4, 2020

Motivation for this change

I wanted to add logtop

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/tools/misc/logtop/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/logtop/default.nix Outdated Show resolved Hide resolved
@starcraft66 starcraft66 force-pushed the starcraft66:master branch from 23d5563 to 8253518 Oct 5, 2020
@starcraft66
Copy link
Contributor Author

@starcraft66 starcraft66 commented Oct 5, 2020

Thanks for the feedback, I have updated my pull request with the requested changes.

@Ma27 Ma27 merged commit 6df7db0 into NixOS:master Oct 6, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8253518"; rev="82535188259dcdc1f447f1fd85046d3934cf5767"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8253518"; rev="82535188259dcdc1f447f1fd85046d3934cf5767"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8253518"; rev="82535188259dcdc1f447f1fd85046d3934cf5767"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8253518"; rev="82535188259dcdc1f447f1fd85046d3934cf5767"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8253518"; rev="82535188259dcdc1f447f1fd85046d3934cf5767"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8253518"; rev="82535188259dcdc1f447f1fd85046d3934cf5767"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8253518"; rev="82535188259dcdc1f447f1fd85046d3934cf5767"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
logtop, logtop.passthru.tests on aarch64-linux Success
Details
logtop, logtop.passthru.tests on x86_64-linux Success
Details
dawidsowa added a commit to dawidsowa/nixpkgs that referenced this pull request Oct 11, 2020
* maintainers: add starcraft66

* logtop: init at 0.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.