Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud20: init #99596

Merged
merged 4 commits into from Oct 7, 2020
Merged

nextcloud20: init #99596

merged 4 commits into from Oct 7, 2020

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 4, 2020

Motivation for this change

Adds nextcloud20 to our package-set. For this change, a few customizations were needed. Please review this commit-by-commit for more details.

To allow users to upgrade to the latest major (even on stable NixOS), the addition of the package (and the nginx changes) should be backported to 20.09 (cc @NixOS/backports ), the changes to the upgrade-path should be left out though[1].

[1] https://nixos.org/manual/nixos/stable/index.html#module-services-nextcloud-maintainer-info

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@lheckemann lheckemann left a comment

LGTM, just a nit.

nixos/modules/services/web-apps/nextcloud.nix Outdated Show resolved Hide resolved
@Ma27 Ma27 requested a review from ajs124 Oct 5, 2020
Ma27 added 3 commits Oct 6, 2020
Please note that this is only for 21.03 since `nextcloud19` is intended
to be the default for the already feature-frozen 20.09 (the bump itself
is supposed to get backported however).
This is a breaking change from `nextcloud20`. However, the affected test
is still passing with an unused database password and socket
authentication.
@lheckemann lheckemann merged commit 41c0f49 into NixOS:master Oct 7, 2020
19 of 20 checks passed
@Ma27 Ma27 deleted the nextcloud20 branch Oct 7, 2020
@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Oct 8, 2020

Ported to 20.09 (to make sure that people can upgrade to latest nextcloud whenever they want) excluding the upgrade-path patch: 8597315, 452603b, 5553758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment