Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blackfire: init at 1.44.0 #99601

Merged
merged 4 commits into from Oct 7, 2020
Merged

blackfire: init at 1.44.0 #99601

merged 4 commits into from Oct 7, 2020

Conversation

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 5, 2020

Motivation for this change

Adds Blackfire, a proprietary profiler for PHP and other languages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jtojnar
Copy link
Contributor Author

@jtojnar jtojnar commented Oct 5, 2020

I successfully created a profile on my NixOS server.

Rendered docs:

image

@etu
Copy link
Contributor

@etu etu commented Oct 5, 2020

cc @NixOS/php

One thought without looking into too deeply: Couldn't the extension/probe bit be part of the file with all other extensions? It has support for extensions that depends on other extensions.

@jtojnar
Copy link
Contributor Author

@jtojnar jtojnar commented Oct 5, 2020

In my experience, separate files are better for automated updates (that reminds me I still need to write an updateScript) and as fair as I can tell the dependencies to other extensions are done through the PHP attribute, which I am passing to callPackage (would be nicer if the extensions were a separate scope with its callPackage but top-level callPackage seems to work now). Also I do not think blackfire depends on anything, or anything on blackfire.

Though there are some incompatible extensions, maybe we could assert that they are not enabled at the same time?

@etu
Copy link
Contributor

@etu etu commented Oct 5, 2020

In my experience, separate files are better for automated updates

Hmm, then we maybe should make a directory for php extension derivations and start splitting out things from "the big file" of all packages and extensions that we have today.

jtojnar added 4 commits Oct 3, 2020
Binary extensions like Blackfire need to know whether PHP was
compiled with ZTS support to work properly.
@jtojnar jtojnar force-pushed the jtojnar:blackfire-agent branch from d542cf7 to 991a67d Oct 7, 2020
@jtojnar jtojnar merged commit 00e3a3a into NixOS:master Oct 7, 2020
19 of 20 checks passed
19 of 20 checks passed
tests tests
Details
action
Details
blackfire, blackfire.passthru.tests, php, php.passthru.tests, phpExtensions.blackfire, phpExtensions.blackfire.passthru.tests on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
blackfire, blackfire.passthru.tests, php, php.passthru.tests, phpExtensions.blackfire, phpExtensions.blackfire.passthru.tests on aarch64-linux Success
Details
blackfire, blackfire.passthru.tests, php, php.passthru.tests, phpExtensions.blackfire, phpExtensions.blackfire.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991a67d"; rev="991a67d45368c331be13ba9414ec9e626c801577"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991a67d"; rev="991a67d45368c331be13ba9414ec9e626c801577"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991a67d"; rev="991a67d45368c331be13ba9414ec9e626c801577"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991a67d"; rev="991a67d45368c331be13ba9414ec9e626c801577"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991a67d"; rev="991a67d45368c331be13ba9414ec9e626c801577"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991a67d"; rev="991a67d45368c331be13ba9414ec9e626c801577"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991a67d"; rev="991a67d45368c331be13ba9414ec9e626c801577"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jtojnar jtojnar deleted the jtojnar:blackfire-agent branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.