Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.cdktf-cli: init at 0.0.19 #99602

Merged

Conversation

@ndarwincorn
Copy link
Contributor

@ndarwincorn ndarwincorn commented Oct 5, 2020

This adds cdktf-cli using generate.sh

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ndarwincorn ndarwincorn force-pushed the add-cdktf-cli-node-package branch from 649fd3c to d9318c9 Oct 16, 2020
@midchildan
Copy link
Member

@midchildan midchildan commented Oct 16, 2020

Hmm, the generated node-packages.nix seems to be broken. Could you revert the changes and try again?

cd pkgs/development/node-packages
git checkout HEAD~ node-packages.nix
./generate.sh

The commit message should also be updated from cdktf-cli-next to cdktf-cli.

@ndarwincorn ndarwincorn force-pushed the add-cdktf-cli-node-package branch from d9318c9 to bebd4f5 Oct 18, 2020
@ndarwincorn ndarwincorn changed the title nodePackages.cdktf-cli-next: init at 0.0.17-pre.3a79d0f2f41205e92d41b… nodePackages.cdktf-cli: init at 0.0.17 Oct 18, 2020
@ndarwincorn
Copy link
Contributor Author

@ndarwincorn ndarwincorn commented Oct 18, 2020

Amended the commit message & subject line for the PR.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

@ndarwincorn If you rebase the PR I can review it and merge it.

@ndarwincorn ndarwincorn force-pushed the add-cdktf-cli-node-package branch from bebd4f5 to 533bce9 Dec 17, 2020
@ndarwincorn ndarwincorn changed the title nodePackages.cdktf-cli: init at 0.0.17 nodePackages.cdktf-cli: init at 0.0.19 Dec 17, 2020
@ndarwincorn
Copy link
Contributor Author

@ndarwincorn ndarwincorn commented Dec 17, 2020

@SuperSandro2000 - rebased, I'll ping you on irc for this as well

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 1, 2021

Result of nixpkgs-review pr 99602 run on x86_64-darwin 1

2 packages failed to build:
  • iosevka
  • lumo
25 packages built:
  • python37Packages.batchspawner
  • python37Packages.dockerspawner
  • python37Packages.jupyterhub
  • python37Packages.jupyterhub-ldapauthenticator
  • python37Packages.jupyterhub-systemdspawner
  • python37Packages.jupyterhub-tmpauthenticator
  • python37Packages.oauthenticator
  • python38Packages.batchspawner
  • python38Packages.dockerspawner
  • python38Packages.jupyterhub
  • python38Packages.jupyterhub-ldapauthenticator
  • python38Packages.jupyterhub-systemdspawner
  • python38Packages.jupyterhub-tmpauthenticator
  • python38Packages.oauthenticator
  • python39Packages.batchspawner
  • python39Packages.dockerspawner
  • python39Packages.jupyterhub
  • python39Packages.jupyterhub-ldapauthenticator
  • python39Packages.jupyterhub-systemdspawner
  • python39Packages.jupyterhub-tmpauthenticator
  • python39Packages.oauthenticator
  • styx
  • vimPlugins.YouCompleteMe
  • vscode-extensions.matklad.rust-analyzer
  • ycmd

iosevka:

building
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! iosevka@3.7.1 build: `verda -f verdafile.js "--jCmd=4" "ttf::iosevka"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the iosevka@3.7.1 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 2, 2021

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or torch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 99602 run on x86_64-linux 1

1 package marked as broken and skipped:
  • image_optim
1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package failed to build and are new build failure:
  • iosevka
75 packages built:
  • antora
  • bitwarden-cli
  • castnow
  • create-cycle-app
  • emojione
  • epgstation
  • etcher
  • flood
  • gtop
  • imgbrd-grabber
  • joplin
  • lessc
  • mastodon-bot
  • mirakurun
  • n8n
  • netlify-cli
  • parity-ui
  • pm2
  • postcss-cli
  • python37Packages.batchspawner
  • python37Packages.dockerspawner
  • python37Packages.jupyterhub
  • python37Packages.jupyterhub-ldapauthenticator
  • python37Packages.jupyterhub-systemdspawner
  • python37Packages.jupyterhub-tmpauthenticator
  • python37Packages.oauthenticator
  • python38Packages.batchspawner
  • python38Packages.dockerspawner
  • python38Packages.jupyterhub
  • python38Packages.jupyterhub-ldapauthenticator
  • python38Packages.jupyterhub-systemdspawner
  • python38Packages.jupyterhub-tmpauthenticator
  • python38Packages.oauthenticator
  • python39Packages.batchspawner
  • python39Packages.dockerspawner
  • python39Packages.jupyterhub
  • python39Packages.jupyterhub-ldapauthenticator
  • python39Packages.jupyterhub-systemdspawner
  • python39Packages.jupyterhub-tmpauthenticator
  • python39Packages.oauthenticator
  • rambox-pro
  • redoc-cli
  • ripcord
  • sage
  • sageWithDoc
  • slack
  • sloc
  • styx
  • teleprompter
  • thelounge
  • triton
  • twemoji-color-font
  • vimPlugins.YouCompleteMe
  • vimPlugins.coc-emmet
  • vimPlugins.coc-go
  • vimPlugins.coc-highlight
  • vimPlugins.coc-html
  • vimPlugins.coc-metals
  • vimPlugins.coc-prettier
  • vimPlugins.coc-r-lsp
  • vimPlugins.coc-rust-analyzer
  • vimPlugins.coc-snippets
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-tslint
  • vimPlugins.coc-tslint-plugin
  • vimPlugins.coc-tsserver
  • vimPlugins.coc-vetur
  • vimPlugins.coc-yaml
  • vimPlugins.coc-yank
  • vscode-extensions.matklad.rust-analyzer
  • vscode-extensions.ms-python.vscode-pylance
  • vscode-extensions.vadimcn.vscode-lldb
  • wasm-text-gen
  • yaml-language-server
  • ycmd

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.jupyterhub-systemdspawner.log:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python38Packages.jupyterhub-systemdspawner.log:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.jupyterhub-systemdspawner.log:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

iosevka timed out.

@SuperSandro2000 SuperSandro2000 merged commit c16929a into NixOS:master Jan 2, 2021
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants