Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mas: init at 1.8.1 #99608

Merged
merged 1 commit into from Apr 2, 2021
Merged

mas: init at 1.8.1 #99608

merged 1 commit into from Apr 2, 2021

Conversation

@zachcoyle
Copy link
Contributor

@zachcoyle zachcoyle commented Oct 5, 2020

Motivation for this change

mas is a command line interface to the Mac App store, and having this package available will allow automation of interactions with the App Store

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Please put this under os-specific.

bsdtar -xf Payload~
'';

buildPhase = "true";
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 27, 2020

Suggested change
buildPhase = "true";
doBuild = false;

maintainers = with maintainers; [ zachcoyle ];
platforms = platforms.darwin;
};

Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 27, 2020

Suggested change

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 28, 2020

Result of nixpkgs-review pr 99608 run on x86_64-darwin 1

1 package built:
  • mas

@zachcoyle
Copy link
Contributor Author

@zachcoyle zachcoyle commented Feb 12, 2021

@SuperSandro2000 Thanks for the feedback! Somehow I didn't see this until now

@zachcoyle zachcoyle changed the title mas: init at 1.7.1 mas: init at 1.8.1 Mar 27, 2021
@zachcoyle zachcoyle requested a review from SuperSandro2000 Mar 27, 2021
pkgs/os-specific/darwin/mas/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/darwin/mas/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Apr 2, 2021

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 99608 run on x86_64-darwin 1

1 package built:
  • mas

@SuperSandro2000 SuperSandro2000 merged commit e702a31 into NixOS:master Apr 2, 2021
21 checks passed
21 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
labels
Details
@github-actions[bot]
action
Details
@ofborg[bot]
mas, mas.passthru.tests on aarch64-linux No attempt
Details
@ofborg[bot]
mas, mas.passthru.tests on x86_64-linux No attempt
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
ofborg-eval ^.^!
Details
@ofborg[bot]
ofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
ofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
ofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7c2e2f"; rev="c7c2e2f54f8ee6934149418f34d03b782a096490"; } ./pkgs/t
Details
@ofborg[bot]
ofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
ofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7c2e2f"; rev="c7c2e2f54f8ee6934149418f34d03b782a096490"; } ./nixos/
Details
@ofborg[bot]
ofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7c2e2f"; rev="c7c2e2f54f8ee6934149418f34d03b782a096490"; } ./nixos/
Details
@ofborg[bot]
ofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7c2e2f"; rev="c7c2e2f54f8ee6934149418f34d03b782a096490"; } ./nixos/
Details
@ofborg[bot]
ofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7c2e2f"; rev="c7c2e2f54f8ee6934149418f34d03b782a096490"; } ./pkgs/t
Details
@ofborg[bot]
ofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7c2e2f"; rev="c7c2e2f54f8ee6934149418f34d03b782a096490"; } ./pkgs/t
Details
@ofborg[bot]
ofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7c2e2f"; rev="c7c2e2f54f8ee6934149418f34d03b782a096490"; } ./pkgs/t
Details
@ofborg[bot]
ofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
ofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
ofborg-eval-started Evaluation started
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants