Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt: 1.3.13 -> 1.4.0 #99612

Closed
wants to merge 1 commit into from
Closed

sbt: 1.3.13 -> 1.4.0 #99612

wants to merge 1 commit into from

Conversation

@JesusMtnez
Copy link
Contributor

@JesusMtnez JesusMtnez commented Oct 5, 2020

Motivation for this change

Bump sbt to 1.4.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@avdv
Copy link
Contributor

@avdv avdv commented Oct 5, 2020

Result of nixpkgs-review pr 99612 1

2 packages failed to build:
  • sbt (simpleBuildTool)
  • sbt-with-scala-native
hash mismatch in fixed-output derivation '/nix/store/ykmn1718xpjzii93cdbvb0liydvv545p-sbt-1.4.0.tgz':
  wanted: sha256:1ldjc05hl121qjy4qs089jywk8ms135h5w9iv8nlcmlrzzgicpas
  got:    sha256:1mgfs732w1c1p7dna7h47x8h073lvjs224fqlpkkvq10153mnxxl
cannot build derivation '/nix/store/d8sswlsinsqd6b1wq2lp165frnhfy3lk-sbt-1.4.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/v2vbxny74izviq3mgj7czdm277vdiqy8-sbt-1.4.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/cq221ggfk6hmg0fkm91nrrfyxf1vzadr-env.drv': 2 dependencies couldn't be built

That is probably because the piccolo.link service is broken (for me it returned 500 internal server errors constantly last week).

@avdv
Copy link
Contributor

@avdv avdv commented Oct 5, 2020

Hi.

Since sbt 1.4 now includes a native client (sbtn), it would be nice to include this in the package as well.

@avdv
Copy link
Contributor

@avdv avdv commented Oct 5, 2020

I have fixed the wrong SHA, removed the piccolo.link and also added the sbtn binary: avdv@9e96abd

@JesusMtnez do you want to integrate these changes in your branch or should I simply create a new PR?

@JesusMtnez
Copy link
Contributor Author

@JesusMtnez JesusMtnez commented Oct 5, 2020

@avdv 🤦 Please, take credit for the changes and open a new PR with your changes, since they really upgrade properly the package. Thank you for including the sbtn client and fixing the wrong sha I have got wrong somehow.

@JesusMtnez JesusMtnez closed this Oct 5, 2020
@JesusMtnez JesusMtnez deleted the update/sbt branch Oct 5, 2020
@avdv avdv mentioned this pull request Oct 5, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants