Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: show CanMultiSession again #99621

Merged
merged 1 commit into from Oct 5, 2020

Conversation

@ttuegel
Copy link
Member

@ttuegel ttuegel commented Oct 5, 2020

Motivation for this change

Fixes the "switch user" function in Plasma < 5.20.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ttuegel ttuegel force-pushed the staging--plasma-switch-user branch from b089372 to 4e384dd Oct 5, 2020
@ttuegel ttuegel changed the title systemd: restore seat_can_multi_session systemd: show CanMultiSession again Oct 5, 2020
@ofborg ofborg bot removed the 6.topic: qt/kde label Oct 5, 2020
@ofborg ofborg bot requested review from flokli, andir and edolstra Oct 5, 2020
@ttuegel ttuegel merged commit b8318e2 into NixOS:staging Oct 5, 2020
19 checks passed
@worldofpeace worldofpeace added this to Done in 20.09 Blockers Oct 5, 2020
@andir
Copy link
Member

@andir andir commented Oct 7, 2020

It might be good to know when we are able to drop this patch again and how to measure that. Simply adding more patches isn't going to sustainable on the long-run.

@flokli flokli mentioned this pull request Oct 26, 2020
10 tasks
NinjaTrappeur pushed a commit that referenced this issue Oct 27, 2020
This was introduced in #99621, but
didn't follow the process documented in
pkgs/os-specific/linux/systemd/default.nix, namely, the `git am` and
`git format-patch` workflow, which caused
`0019-revert-get-rid-of-seat_can_multi_session.patch` to not apply with
`git am` due to missing authorship information.

I did apply this patch manually, and copied authorship information from
4e384dd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants