Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epgstation: 1.7.4 -> 1.7.5 #99632

Merged
merged 2 commits into from Nov 3, 2020
Merged

epgstation: 1.7.4 -> 1.7.5 #99632

merged 2 commits into from Nov 3, 2020

Conversation

@midchildan
Copy link
Member

@midchildan midchildan commented Oct 5, 2020

Motivation for this change
  • bump version
  • change existing scripts to make use of passthru.updateScript
  • change name from node_EPGStation to EPGStation.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@midchildan
Copy link
Member Author

@midchildan midchildan commented Oct 6, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 6, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@midchildan midchildan force-pushed the update/epgstation branch from b31ff92 to e2a3a02 Oct 20, 2020
Copy link
Contributor

@wamserma wamserma left a comment

LGTM at first glance.

@wamserma
Copy link
Contributor

@wamserma wamserma commented Nov 2, 2020

/marvin needs_merger

@midchildan
Copy link
Member Author

@midchildan midchildan commented Nov 3, 2020

Thanks! JFYI the command for changing statuses is /status.

/status needs_merger

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Nov 3, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@midchildan
Copy link
Member Author

@midchildan midchildan commented Nov 3, 2020

Oh.

@wamserma
Copy link
Contributor

@wamserma wamserma commented Nov 3, 2020

/status needs_merger

@wamserma
Copy link
Contributor

@wamserma wamserma commented Nov 3, 2020

Thanks! JFYI the command for changing statuses is /status.

/status needs_merger

I always mix this up. -.-

timokau
timokau approved these changes Nov 3, 2020
Copy link
Member

@timokau timokau left a comment

This looks good to me. @cideM, what is the status on node packages? Should I just merge this or do you want to bundle it somehow?

@cideM
Copy link
Contributor

@cideM cideM commented Nov 3, 2020

Since there are no conflicts I'd just merge this right now. For follow-up merge conflicts I'd then bundle them

@timokau
Copy link
Member

@timokau timokau commented Nov 3, 2020

Okay, thanks! Also thank you for the review @wamserma.

@timokau timokau merged commit 6c13df3 into NixOS:master Nov 3, 2020
19 checks passed
@midchildan midchildan deleted the update/epgstation branch Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants