Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmux: malloc_trim memory after history is cleaned #99633

Closed
wants to merge 1 commit into from

Conversation

@svalaskevicius
Copy link
Contributor

@svalaskevicius svalaskevicius commented Oct 5, 2020

Motivation for this change

reduce tmux memory usage

Things done

Applied a patch that was suggested by tmux maintainer. See tmux/tmux#2408 for more info.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@svalaskevicius
Copy link
Contributor Author

@svalaskevicius svalaskevicius commented Oct 5, 2020

Result of nixpkgs-review pr 99633 1

4 packages built:
  • byobu
  • overmind
  • tmux
  • tmux-cssh

@cole-h
Copy link
Member

@cole-h cole-h commented Oct 5, 2020

IMHO, we should wait until the patch is merged upstream and then fetchpatch it.

@svalaskevicius
Copy link
Contributor Author

@svalaskevicius svalaskevicius commented Oct 6, 2020

@cole-h it has been applied on master now.

not sure how to use fetchpatch though, esp that the master version is slightly different than 3.1b - the patch needs some slight adjustments (to not be rejected), which has been done in this one

ofc we can also wait until a new stable version is released, then this patch is going to be irrelevant :)

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

not sure how to use fetchpatch though

it normalizes the patch compared to fetchurl to better apply.

esp that the master version is slightly different than 3.1b - the patch needs some slight adjustments (to not be rejected), which has been done in this one

ofc we can also wait until a new stable version is released, then this patch is going to be irrelevant :)

breaking tmux with bugs will hit a lot of people. Just being careful when fetching pre release patches.

@svalaskevicius
Copy link
Contributor Author

@svalaskevicius svalaskevicius commented Nov 27, 2020

Not sure how to respond :)

If everyone prefers to wait (maybe it's already released and can be upgraded cleanly? - I haven't checked), I'm happy for this pr to be simply closed :)

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 27, 2020

@ofborg eval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants