Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No Merge] pythonPackages.*: bump minor versions #99636

Closed
wants to merge 325 commits into from

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 5, 2020

Motivation for this change

DO NOT MERGE

follow up to #99635

example of running:

export GITHUB_API_TOKEN=<redacted>
./maintainers/scripts/update-python-libraries --use-pkgs-prefix --commit --target minor ./pkgs/development/python-modules/*/default.nix

with github fetcher enabled.

This PR will mostly be used to identify script update errors.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer jonringer requested a review from FRidh Oct 5, 2020
@jonringer jonringer mentioned this pull request Oct 5, 2020
4 of 10 tasks complete
@jonringer jonringer force-pushed the jonringer:example-python-update branch from 8c65f78 to ec45df7 Oct 5, 2020
@jonringer jonringer changed the title pythonPackages.*: bump minor versions [No Merge] pythonPackages.*: bump minor versions Oct 5, 2020
jonringer added 19 commits Oct 5, 2020
jonringer added 21 commits Oct 5, 2020
@jonringer jonringer force-pushed the jonringer:example-python-update branch from ec45df7 to 7dd03fb Oct 5, 2020
buildPythonPackage {
pname = "azure-mgmt-commerce";
version = "1.0.1";
version = "1.8.2";

src = fetchFromGitHub {
owner = "Azure";
repo = "azure-sdk-for-python";
rev = "ee5b47525d6c1eae3b1fd5f65b0421eab62a6e6f";
sha256 = "0xzdn7da5c3q5knh033vbsqk36vwbm75cx8vf10x0yj58krb4kn4";
rev = "azure-core_${version}";
sha256 = "1nx0mwkvwy34dpmkp3gbbjxvz12cnj2xr8lrxg1hq9clqkrl9yl5";
};
Comment on lines 11 to 20

This comment has been minimized.

@jonringer

jonringer Oct 5, 2020
Author Contributor

hmm, large mono repos....

This comment has been minimized.

@jonringer

jonringer Oct 5, 2020
Author Contributor

easiest solution I could think of would be to blacklist the repo. Or instead of making a "one-off" exception, just convert these to using fetchPypi

This comment has been minimized.

@jonringer

jonringer Oct 5, 2020
Author Contributor

there's only this and one other azure-mgmt package which are affected by it

thoughts? @FRidh

This comment has been minimized.

@jonringer

jonringer Oct 5, 2020
Author Contributor

I'm leaning towards just using fetchpypi, as I don't think tests are ran anyway

@@ -8,13 +8,13 @@ assert !useUnrar -> libarchive != null;

buildPythonPackage {

This comment has been minimized.

@jonringer

jonringer Oct 5, 2020
Author Contributor

this is missing a rec, but would otherwise be correct

Suggested change
buildPythonPackage {
buildPythonPackage rec {
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 7, 2020

related PRs have been merged

@jonringer jonringer closed this Oct 7, 2020
@jonringer jonringer deleted the jonringer:example-python-update branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.