Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pineapple: init at 1174 #99656

Closed
wants to merge 1 commit into from
Closed

Conversation

@IvarWithoutBones
Copy link
Contributor

@IvarWithoutBones IvarWithoutBones commented Oct 5, 2020

Motivation for this change

Adds pineappleEA.

Building from source proved to be too much of a hastle, so for now I've just used the provided appimage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@aanderse
Copy link
Member

@aanderse aanderse commented Oct 5, 2020

👍

A shame things didn't work out with #84117 yet. I assume at some point in the future the plan is to build from source, right?

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 5, 2020

get a message when launching the application, not sure if this a know issue:


(Missing fuses - Missing BOOT0 - Missing BCPKG2-1-Normal-Main - Missing PRODINFO)

@MGThePro
Copy link

@MGThePro MGThePro commented Oct 5, 2020

get a message when launching the application, not sure if this a know issue:


(Missing fuses - Missing BOOT0 - Missing BCPKG2-1-Normal-Main - Missing PRODINFO)

This is normal, running official games requires dumping the keys from a Switch so yuzu can decrypt the game files. Homebrew applications may not need this, but I'm not 100% sure about that.

@IvarWithoutBones
Copy link
Contributor Author

@IvarWithoutBones IvarWithoutBones commented Oct 5, 2020

👍

A shame things didn't work out with #84117 yet. I assume at some point in the future the plan is to build from source, right?

Yes, though for now i hope this is fine. Building from source has proven to be quite a bit of trouble, which i currently do not have the time to get working. I definitely plan to do this in the future.

This is normal, running official games requires dumping the keys from a Switch so yuzu can decrypt the game files. Homebrew applications may not need this, but I'm not 100% sure about that.

Homebrew applications indeed do not need this. These fuses (or keys) are used to decrypt Nintendo's propietary formats for their games. For legal reasons, they are not provided with the emulator.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 28, 2020

@IvarWithoutBones please resolve the merge conflict.

@IvarWithoutBones IvarWithoutBones force-pushed the pineapple branch 2 times, most recently from 7bbc0e2 to 879dc09 Nov 30, 2020
@IvarWithoutBones IvarWithoutBones changed the title pineapple: init at 1013 pineapple: init at 1174 Nov 30, 2020
@IvarWithoutBones
Copy link
Contributor Author

@IvarWithoutBones IvarWithoutBones commented Nov 30, 2020

@IvarWithoutBones please resolve the merge conflict.

Done 👍

Also updated it to the latest version.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 27, 2020

Result of nixpkgs-review pr 99656 run on x86_64-linux 1

1 package built:
  • pineapple

@aanderse
Copy link
Member

@aanderse aanderse commented Dec 27, 2020

@IvarWithoutBones since yuzu was merged do we still need this PR?

@IvarWithoutBones
Copy link
Contributor Author

@IvarWithoutBones IvarWithoutBones commented Dec 28, 2020

@IvarWithoutBones since yuzu was merged do we still need this PR?

This is the early-access branch, i believe it's still nice to have. This gets features quicker than mainline yuzu.

The reason we're currently not building from source is that the sourcecode is not easily accessible, it's on this service called Anonfiles which sounds a little too sketchy and nonreproducible to fetch from. I'm currently in touch with pineapple's maintainers, hoping I can help them make the sourcecode available on Github.

I've also just updated the package to the latest available version.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 28, 2020

Result of nixpkgs-review pr 99656 run on x86_64-linux 1

1 package built:
  • pineapple

cp -r ${appimageContents}/usr/share/icons $out/share
'';

meta = with stdenv.lib; {
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jan 18, 2021

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

@@ -0,0 +1,33 @@
{ stdenv, appimageTools, fetchurl }:
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jan 18, 2021

Suggested change
{ stdenv, appimageTools, fetchurl }:
{ lib, appimageTools, fetchurl }:

@IvarWithoutBones
Copy link
Contributor Author

@IvarWithoutBones IvarWithoutBones commented Jan 25, 2021

I've gotten in contact with the pineapple guys, and helped them out getting the early access source code available on GitHub.
Closing this PR in favour of #110810, as this builds it from source and is more up-to-date.

@IvarWithoutBones IvarWithoutBones deleted the pineapple branch Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants