Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librepcb: 0.1.4 -> 0.1.5 #99659

Closed
wants to merge 8 commits into from
Closed

librepcb: 0.1.4 -> 0.1.5 #99659

wants to merge 8 commits into from

Conversation

@Luz
Copy link
Contributor

@Luz Luz commented Oct 5, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [ x ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [ x ] Fits CONTRIBUTING.md.
Copy link
Member

@prusnak prusnak left a comment

The project uses tags, so we can leverage this by fetching the tag instead of the commit hash. See suggestion below.


src = fetchFromGitHub {
owner = "LibrePCB";
repo = "LibrePCB";
fetchSubmodules = true;
rev = "ae04eef5a71b5ba66ae2cee6b631c1c933ace535";
sha256 = "0wk5qny1jb6n4mwyyrs7syir3hmwxlwazcd80bpxharmsj7p0rzc";
rev = "a435c5095c6f94df4da130fe832ea97f42d17901";
Copy link
Member

@prusnak prusnak Nov 4, 2020

Suggested change
rev = "a435c5095c6f94df4da130fe832ea97f42d17901";
rev = version;

prusnak
prusnak approved these changes Nov 5, 2020
@prusnak
Copy link
Member

@prusnak prusnak commented Nov 5, 2020

Please squash the second commit into the first one

NeQuissimus and others added 8 commits Nov 5, 2020
9544c60 / NixOS#96672 removed the samba option
`syncPasswordsByPam`.
Need to remove this option from the pam module, otherwise it will cause build errors
Otherwise, it's possible building a flake may cause the live CD to run
out of memory.
This fixes both `nix-shell` failing to eval with `nixUnstable`, as well
as ofborg's failure to eval on aarch64 due to passing an "unexpected
arg" (https://github.com/NixOS/ofborg/blob/1112e3a8c8621203fae71283d700e0383b5e1e80/ofborg/src/nix.rs#L334-L340).
@Luz Luz force-pushed the librepcb-0.1.5 branch from e0634d7 to 2c3b8f2 Nov 5, 2020
@Luz Luz requested review from Ericson2314 and nbp as code owners Nov 5, 2020
@Luz Luz closed this Nov 5, 2020
@Luz Luz deleted the librepcb-0.1.5 branch Nov 5, 2020
@Luz
Copy link
Contributor Author

@Luz Luz commented Nov 5, 2020

reopened a fresh one, hope thats ok...
#102954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants