Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.islpy: fix build #99660

Merged
merged 1 commit into from Oct 5, 2020
Merged

pythonPackages.islpy: fix build #99660

merged 1 commit into from Oct 5, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 5, 2020

Motivation for this change

ZHF: #97479

islpy has switched from cffi to pybind11. Convert to pytestCheckHook while we're at it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
also convert to pytestCheckHook
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 99660 1

4 packages built:
  • python37Packages.islpy
  • python37Packages.loo-py
  • python38Packages.islpy
  • python38Packages.loo-py

@jonringer jonringer merged commit be1281b into NixOS:master Oct 5, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants