Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sublime-music: 0.11.7 -> 0.11.10 #99663

Merged
merged 4 commits into from Apr 1, 2021

Conversation

@sumnerevans
Copy link
Member

@sumnerevans sumnerevans commented Oct 5, 2020

Motivation for this change

This PR

  • Updates Sublime Music to v0.11.10
  • Adds functionality to install the .desktop and .metainfo.xml files as well as the icon for Sublime Music. I had to change the source to use the .tar.gz from the Releases page instead of the source from PyPi because the tar file has those additional resources.
  • Adds me (@sumnerevans) as a maintainer for the sublime-music package. I'm the creator of Sublime Music, and I recently switched to NixOS, so I figured it would be good to add myself to the maintainers list.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@sumnerevans
Copy link
Member Author

@sumnerevans sumnerevans commented Oct 14, 2020

Just added a commit to bump to the latest release of Sublime Music: https://gitlab.com/sublime-music/sublime-music/-/releases/v0.11.10

@sumnerevans
Copy link
Member Author

@sumnerevans sumnerevans commented Oct 20, 2020

@albakham when you have a chance.

@albakham
Copy link
Member

@albakham albakham commented Nov 4, 2020

@sumnerevans sumnerevans force-pushed the sublime-music-metadata branch from b8903e4 to 08f3f7e Nov 4, 2020
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 24, 2020

Looks like it does not build on x86_64-linux but it does on aarch64-linux according to CI.

@sumnerevans
Copy link
Member Author

@sumnerevans sumnerevans commented Mar 16, 2021

OK, it looks like I've fixed the build, now.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/applications/audio/sublime-music/default.nix Outdated Show resolved Hide resolved
@sumnerevans sumnerevans force-pushed the sublime-music-metadata branch from fc6c886 to 0b179bd Mar 22, 2021
Added the 'bleach' dependency and converted to using the
tarball provided in the upstream release.
@sumnerevans sumnerevans force-pushed the sublime-music-metadata branch from 0b179bd to f5ae7e4 Mar 22, 2021
@SuperSandro2000 SuperSandro2000 merged commit 682e8ac into NixOS:master Apr 1, 2021
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants