Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngspice: 31 -> 32 #99664

Merged
merged 1 commit into from Oct 11, 2020
Merged

ngspice: 31 -> 32 #99664

merged 1 commit into from Oct 11, 2020

Conversation

@matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Oct 5, 2020

Motivation for this change

Updates ngspice to v32.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bgamari
Copy link
Contributor

@bgamari bgamari commented Oct 9, 2020

This looks good to me.

bgamari
bgamari approved these changes Oct 9, 2020
@bjornfor bjornfor merged commit 937c259 into NixOS:master Oct 11, 2020
19 checks passed
@matthuszagh matthuszagh deleted the ngspice branch Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants