Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeowners: add cprussin as a codeowner for nodejs & deno #99666

Closed

Conversation

@cprussin
Copy link

@cprussin cprussin commented Oct 5, 2020

Motivation for this change

Adding myself as a codeowner so I can start helping maintain nodejs/deno/node modules.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@cprussin cprussin requested a review from edolstra as a code owner Oct 5, 2020
@cprussin
Copy link
Author

@cprussin cprussin commented Oct 5, 2020

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 5, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/call-for-nodepackages-maintainers/9176/11

@zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 5, 2020

https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners

The people you choose as code owners must have write permissions for the repository.

@cprussin
Copy link
Author

@cprussin cprussin commented Oct 5, 2020

https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners

The people you choose as code owners must have write permissions for the repository.

@jonringer can you please advise? Can/should I be granted write access?

Copy link
Contributor

@jonringer jonringer left a comment

ah interesting, I added myself as a CODEOWNER after becoming a committer.... And I don't think we should be giving out commit access until someone has proven themselves.... I'm not entirely sure.

In relation to the original discourse, there may be a way to add yourself as a maintainer to the main node-packages.nix, but I'm not familiar enough with nix-node to know where that should be

@cprussin
Copy link
Author

@cprussin cprussin commented Oct 5, 2020

OK let me close this PR and move the discussion back to discourse and I'll follow up however we decide there. Thanks.

@cprussin cprussin closed this Oct 5, 2020
@cprussin cprussin deleted the add-cprussin-as-codeowner-for-node branch Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants