Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caffeine-ng: add missing dependencies, fix bin paths #99667

merged 1 commit into from Oct 13, 2020


Copy link

@uvNikita uvNikita commented Oct 5, 2020

Motivation for this change

caffeine-ng makes os.system calls expecting some binaries in the path, see file. This PR adds missing dependencies and patches mentioned file to use binaries from the nix store.

Closure size change: 376.3M -> 509.3M

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Copy link

@nixos-discourse nixos-discourse commented Oct 13, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

@uvNikita uvNikita force-pushed the caffeine-ng/fix-bin-paths branch from 8b2bb2e to 9459bc9 Oct 13, 2020
@uvNikita uvNikita force-pushed the caffeine-ng/fix-bin-paths branch from 9459bc9 to 35e0d35 Oct 13, 2020
veprbl approved these changes Oct 13, 2020
@veprbl veprbl merged commit 6cc0fc9 into NixOS:master Oct 13, 2020
18 of 19 checks passed
veprbl added a commit that referenced this issue Oct 13, 2020
@uvNikita uvNikita deleted the caffeine-ng/fix-bin-paths branch Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants