Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update elm-language-server, and other elm tools #99671

Merged
merged 1 commit into from Oct 6, 2020

Conversation

@andys8
Copy link
Contributor

@andys8 andys8 commented Oct 5, 2020

Ran the update script

elm-hot-webpack-loader 1.1.7
elm-test 0.19.1-revision4
elm-webpack-loader 6.0.1
elm-language-server 1.12.0
create-elm-app 5.2.1

Similar to past PRs: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+author%3A%40me+is%3Aclosed+elm

Motivation for this change

Updating the elm-language-server

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@turboMaCk

elm-hot-webpack-loader 1.1.7
elm-test 0.19.1-revision4
elm-webpack-loader 6.0.1
elm-language-server 1.12.0
create-elm-app 5.2.1
@turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Oct 6, 2020

thanks @andys8. I was about to do this myself because since I need elm-test-0.19.1-revision4.
LGTM cc @domenkozar

@domenkozar
Copy link
Member

@domenkozar domenkozar commented Oct 6, 2020

@GrahamcOfBorg build elmPackages

@domenkozar domenkozar merged commit 8158378 into NixOS:master Oct 6, 2020
19 of 20 checks passed
@jaredramirez jaredramirez mentioned this pull request Oct 19, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants