Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-ndi: 4.7.1 -> 4.9.1 #99683

Merged
merged 1 commit into from Oct 18, 2020
Merged

obs-ndi: 4.7.1 -> 4.9.1 #99683

merged 1 commit into from Oct 18, 2020

Conversation

@jshcmpbll
Copy link

@jshcmpbll jshcmpbll commented Oct 6, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@sarcasticadmin sarcasticadmin left a comment

@jshcmpbll had a comment for adding you as a maintainer to this nixpkg 🙂

@@ -34,7 +34,7 @@ stdenv.mkDerivation rec {
meta = with stdenv.lib; {
description = "Network A/V plugin for OBS Studio";
homepage = "https://github.com/Palakis/obs-ndi";
maintainers = with maintainers; [ peti ];
maintainers = with maintainers; [ peti jshcmpbll ];

This comment has been minimized.

@jshcmpbll

jshcmpbll Oct 8, 2020
Author

I did not! Thanks :D

@jshcmpbll jshcmpbll force-pushed the jshcmpbll:issue-99681 branch 3 times, most recently from ff5e3fc to 59582e6 Oct 18, 2020
Joshua Campbell
@jshcmpbll jshcmpbll force-pushed the jshcmpbll:issue-99681 branch from 59582e6 to c7bbc9b Oct 18, 2020
@ofborg ofborg bot requested a review from peti Oct 18, 2020
@peti peti merged commit 265fc30 into NixOS:master Oct 18, 2020
17 checks passed
17 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7bbc9b"; rev="c7bbc9b9f8fc602e983319ff2f47fa3810f4bf4c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7bbc9b"; rev="c7bbc9b9f8fc602e983319ff2f47fa3810f4bf4c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7bbc9b"; rev="c7bbc9b9f8fc602e983319ff2f47fa3810f4bf4c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7bbc9b"; rev="c7bbc9b9f8fc602e983319ff2f47fa3810f4bf4c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7bbc9b"; rev="c7bbc9b9f8fc602e983319ff2f47fa3810f4bf4c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7bbc9b"; rev="c7bbc9b9f8fc602e983319ff2f47fa3810f4bf4c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c7bbc9b"; rev="c7bbc9b9f8fc602e983319ff2f47fa3810f4bf4c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jshcmpbll jshcmpbll deleted the jshcmpbll:issue-99681 branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.