Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multilockscreen: init at 1.0.0 #99688

Merged
merged 1 commit into from Nov 25, 2020
Merged

multilockscreen: init at 1.0.0 #99688

merged 1 commit into from Nov 25, 2020

Conversation

@kylesferrazza
Copy link
Member

@kylesferrazza kylesferrazza commented Oct 6, 2020

closes #99637

Motivation for this change

The aforementioned issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@endgame endgame left a comment

Builds fine with nix-build -A multilockscreen https://github.com/kylesferrazza/nixpkgs/archive/fix-99637.tar.gz on my NixOS but I didn't test it.

Nix expressions look pretty good to my amateur eyes but there are a couple of tweaks I'd suggest.

I don't have merge privs so this is about all I can do.

pkgs/misc/screensavers/multilockscreen/default.nix Outdated Show resolved Hide resolved
pkgs/misc/screensavers/multilockscreen/default.nix Outdated Show resolved Hide resolved
pkgs/misc/screensavers/multilockscreen/default.nix Outdated Show resolved Hide resolved
@kylesferrazza kylesferrazza changed the title multilockscreen: init at 3.0.1 multilockscreen: init at 1.0.0 Oct 6, 2020
@endgame
Copy link
Contributor

@endgame endgame commented Oct 6, 2020

Much better, thanks. One last nit, then hopefully someone with merge rights can either give you final feedback or get it into the main tree.

@endgame
Copy link
Contributor

@endgame endgame commented Oct 21, 2020

Looks OK; I have nothing useful to add. Hopefully someone with merge power sees this.

@kylesferrazza
Copy link
Member Author

@kylesferrazza kylesferrazza commented Oct 21, 2020

@endgame thanks, can you click "approve" so the green check comes up and the label gets applied? :)

@kylesferrazza
Copy link
Member Author

@kylesferrazza kylesferrazza commented Nov 24, 2020

bump?

@endgame
Copy link
Contributor

@endgame endgame commented Nov 24, 2020

I don't have merge permissions. Best bet is to ask for some eyes on IRC (freenode, #nixos)

@Infinisil Infinisil merged commit bb59f10 into NixOS:master Nov 25, 2020
19 checks passed
@kylesferrazza kylesferrazza deleted the fix-99637 branch Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants