Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] python3Packages.toggl-cli: 2.1.0 -> 2.2.1 #99691

Merged
merged 4 commits into from Oct 6, 2020

Conversation

@austinbutler
Copy link
Contributor

@austinbutler austinbutler commented Oct 6, 2020

Motivation for this change

Backport of: #99607

ZHF: #97479
https://hydra.nixos.org/build/128023281
https://hydra.nixos.org/build/127640071

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@endgame
Copy link
Contributor

@endgame endgame commented Oct 6, 2020

Builds on NixOS with nix-build -A python3Packages.toggl-cli https://github.com/austinbutler/nixpkgs/archive/toggl-cli-backport.tar.gz, though I didn't test beyond result/bin/toggl --help. I assume the individual commits are all cherry-picks from master and therefore fine.

I don't have merge powers so that's all I can offer.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 99691 1

@jonringer jonringer merged commit 9050ae0 into NixOS:master Oct 6, 2020
16 checks passed
@austinbutler austinbutler deleted the toggl-cli-backport branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants