Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/plasma5: add spectacle default #99693

Merged
merged 1 commit into from Oct 6, 2020

Conversation

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 6, 2020

Fixes #99680.

In the future I think it would be nice if plasma5 could assume
an approach for an interface we have in the gnome3 module 0.
Notably being able to exclude packages with an option from
the default environment and having a default environment that
is useful to the average user. See 1, currently plasma5 defaults
are very "hard core hacker" with the most bare bones setup.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Fixes NixOS#99680.

In the future I think it would be nice if plasma5 could assume
an approach for an interface we have in the gnome3 module [0].
Notably being able to exclude packages with an option from
the default environment and having a default environment that
is useful to the average user. See [1], currently plasma5 defaults
are very "hard core hacker" with the most bare bones setup.

[0]: NixOS#67310
[1]: NixOS#67310 (comment)
@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Oct 6, 2020

@ofborg test plasma5

@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Oct 6, 2020

This needs some sort of release note, I think.

xfix
xfix approved these changes Oct 6, 2020
Copy link
Contributor

@xfix xfix left a comment

I like the idea of including Spectacle by default, most KDE users will probably want to have it installed, and I think it would be useful to have on Live CD.

@adisbladis
Copy link
Member

@adisbladis adisbladis commented Oct 6, 2020

This needs some sort of release note, I think.

I don't think it does, it's a really minor edit. But we should add backports to relevant channels.

@adisbladis adisbladis merged commit f26d663 into NixOS:master Oct 6, 2020
18 checks passed
@worldofpeace worldofpeace deleted the spectacle-in-plasma5-default branch Oct 6, 2020
@worldofpeace
Copy link
Contributor Author

@worldofpeace worldofpeace commented Oct 6, 2020

backported to 20.09 ad10d15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants