Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.rarfile: 3.0 -> 4.0 #99708

Merged
merged 1 commit into from Oct 7, 2020
Merged

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 6, 2020

Motivation for this change

as noted in #99636 (comment) , using the previous source would cause issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer jonringer force-pushed the jonringer:bump-rarfile branch from 687aeea to a8a3e17 Oct 7, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 7, 2020

https://github.com/NixOS/nixpkgs/pull/99708
5 packages built:
beets python37Packages.rarfile python37Packages.subliminal python38Packages.rarfile python38Packages.subliminal
@jonringer jonringer merged commit 8a75ad4 into NixOS:master Oct 7, 2020
2 of 4 checks passed
2 of 4 checks passed
tests tests
Details
action
Details
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
grahamcofborg-eval Checking original out paths
Details
@jonringer jonringer deleted the jonringer:bump-rarfile branch Oct 7, 2020
@ofborg ofborg bot added the 8.has: clean-up label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.