Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smos: init at 0.1.0 #99713

Merged
merged 2 commits into from Oct 12, 2020
Merged

smos: init at 0.1.0 #99713

merged 2 commits into from Oct 12, 2020

Conversation

@NorfairKing
Copy link
Contributor

@NorfairKing NorfairKing commented Oct 6, 2020

I wrote smos at
https://github.com/NorfairKing/smos
and I use it on NixOS so I know that this works.

The zip file that's being downloaded is the zipped-up version for a nix-expression at https://github.com/NorfairKing/smos/blob/development/ci.nix attribute release-static.
These are static executables, so they should have no runtime dependencies.
The zip file also contains bash, zsh and fish completions, as well as a new mime typeand a.desktop` file.

Some questions:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@NorfairKing
Copy link
Contributor Author

@NorfairKing NorfairKing commented Oct 6, 2020

I'm not sure what to do with the evaluation error about me as a maintainer...

@NorfairKing
Copy link
Contributor Author

@NorfairKing NorfairKing commented Oct 8, 2020

@domenkozar Who should I ask for review on this?

@NorfairKing
Copy link
Contributor Author

@NorfairKing NorfairKing commented Oct 9, 2020

@domenkozar Yes I understand that there's a failure there but I have no clue what to do about it. I don't see anyone else's github id specified in the maintainers file...
I also don't know which build to run to check if I fixed things correctly.

@domenkozar
Copy link
Member

@domenkozar domenkozar commented Oct 9, 2020

It may be that you need to rebase? Each maintainer entry has githubId attached to it.

@NorfairKing
Copy link
Contributor Author

@NorfairKing NorfairKing commented Oct 9, 2020

Oh wauw yeah, great job spotting that. I was working of a very old version.

@NorfairKing
Copy link
Contributor Author

@NorfairKing NorfairKing commented Oct 12, 2020

Trying to get rid of this seemingly unrelated eval error.

@NorfairKing
Copy link
Contributor Author

@NorfairKing NorfairKing commented Oct 12, 2020

Now CI seems to have pased. @domenkozar What's next?

@domenkozar
Copy link
Member

@domenkozar domenkozar commented Oct 12, 2020

@GrahamcOfBorg build smos

@domenkozar
Copy link
Member

@domenkozar domenkozar commented Oct 12, 2020

You need to add an entry to pkgs/top-level/all-packages.nix

@NorfairKing
Copy link
Contributor Author

@NorfairKing NorfairKing commented Oct 12, 2020

Done as well.

@GrahamcOfBorg build smos

@domenkozar domenkozar merged commit 89f961c into NixOS:master Oct 12, 2020
5 of 6 checks passed
@NorfairKing
Copy link
Contributor Author

@NorfairKing NorfairKing commented Oct 12, 2020

@domenkozar WOHOO THANKS

Would you please also answer my questions:

@domenkozar
Copy link
Member

@domenkozar domenkozar commented Oct 12, 2020

Should I import the nix file in the smos repo instead?

You can't do that since Hydra doesn't allow import from derivation, we will be able to do that with flakes.

There is a module at https://github.com/NorfairKing/smos/blob/development/nix/module.nix, can I somehow add it to nixpkgs without moving it out of the smos repo?

Same answer as above :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants