Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ardour: 6.2 -> 6.3 #99721

Merged
merged 1 commit into from Nov 5, 2020
Merged

ardour: 6.2 -> 6.3 #99721

merged 1 commit into from Nov 5, 2020

Conversation

@magnetophon
Copy link
Member

@magnetophon magnetophon commented Oct 6, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@eadwu
Copy link
Member

@eadwu eadwu commented Nov 5, 2020

Can't really tell if this is working, no GUI is popping up and no errors are showing.

Ardour: [INFO]: Loading plugin meta data file /nix/store/ccw9cqlmxi7lbpihrs0f8d69anpqhnsf-ardour-6.3/share/ardour6/plugin_metadata/plugin_tags
Ardour: [INFO]: Loading default ui configuration file /nix/store/ccw9cqlmxi7lbpihrs0f8d69anpqhnsf-ardour-6.3/etc/ardour6/default_ui_config
Ardour: [INFO]: Loading 449 MIDI patches from /nix/store/ccw9cqlmxi7lbpihrs0f8d69anpqhnsf-ardour-6.3/share/ardour6/patchfiles
Ardour: [INFO]: Loading color file /nix/store/ccw9cqlmxi7lbpihrs0f8d69anpqhnsf-ardour-6.3/share/ardour6/themes/dark-ardour.colors

@magnetophon
Copy link
Member Author

@magnetophon magnetophon commented Nov 5, 2020

@eadwu That is really odd. For one it just works here, but also: in the past, when ardour broke for some reason, it has always given an error.
Could you try again please?

@eadwu
Copy link
Member

@eadwu eadwu commented Nov 5, 2020

Ah found out the reason, https://discourse.ardour.org/t/ardour-doesnt-start-but-doesnt-crash-just-hangs-there-stuck/89118. Took a while to find since I didn't have an explicit error, anyway working fine on my end after the fix GTK2_RC_FILES=/nonexistent ardour6.

Anyway working fine, though to silence the gtk errors one might wrap GTK_PATH with the /lib/gtk-2.0 paths in gtk2 and gnome3.gnome-themes-extra.

veprbl
veprbl approved these changes Nov 5, 2020
Copy link
Member

@veprbl veprbl left a comment

LGTM

@roberth
Copy link
Member

@roberth roberth commented Nov 5, 2020

@roberth roberth merged commit f15a00e into NixOS:master Nov 5, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
ardour, ardour.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
ardour, ardour.passthru.tests on x86_64-linux Success
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c237eb"; rev="9c237eb7ab81f47e33d76c93441d44f43dafd53d"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c237eb"; rev="9c237eb7ab81f47e33d76c93441d44f43dafd53d"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c237eb"; rev="9c237eb7ab81f47e33d76c93441d44f43dafd53d"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c237eb"; rev="9c237eb7ab81f47e33d76c93441d44f43dafd53d"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c237eb"; rev="9c237eb7ab81f47e33d76c93441d44f43dafd53d"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c237eb"; rev="9c237eb7ab81f47e33d76c93441d44f43dafd53d"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c237eb"; rev="9c237eb7ab81f47e33d76c93441d44f43dafd53d"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@magnetophon magnetophon deleted the ardour branch Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants