Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell-language-server: c476992f43 -> 93a3b53b6c #99723

Closed
wants to merge 1 commit into from
Closed

haskell-language-server: c476992f43 -> 93a3b53b6c #99723

wants to merge 1 commit into from

Conversation

@Cmdv
Copy link

@Cmdv Cmdv commented Oct 6, 2020

Motivation for this change

Version 0.5.0 of haskell-language-server was recently released so updating package to match.

This could also be a used with #99519

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@srid
Copy link
Contributor

@srid srid commented Oct 6, 2020

@Cmdv
Copy link
Author

@Cmdv Cmdv commented Oct 6, 2020

@srid ah yes you're right, I didn't realise PR went into haskell-updates branch. So when searching I was only looking on master 🤦

Will close this for now 😄

How often does that branch get merged into master?

@Cmdv Cmdv closed this Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants